Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin je peux router avec des règles dont l'opérateur est "n'est pas" #9423

Merged
merged 6 commits into from
Sep 6, 2023

Conversation

E-L-T
Copy link
Contributor

@E-L-T E-L-T commented Aug 29, 2023

closes #9385

Screencast.from.29-08-2023.22.51.56.webm

@what-the-diff
Copy link

what-the-diff bot commented Aug 29, 2023

PR Summary

  • New methods introduced to handle operator tags
    The methods operator_name and operator_tag were added to the file one_groupe_management_component.rb. These produce the naming for routing rule classifications as well as their associated select tag respectively. Another added method, options_for_operator_tag, assists these by generating selectable options for the operator tag.

  • Visual updates to the management component view
    The one_groupe_management_component.html.haml file has been updated to include the aforementioned operator tags in the graphical user interface.

  • Update action handling for different operators
    Changes were made to routing_controller.rb to accommodate different operator names in the update function. This provides better flexibility in rule management.

  • Testing enhancements
    The testing file routing_controller_spec.rb now includes the parameter operator_name. This addition improves our ability to test the update function with specified operator names, enhancing the system's test coverage.

  • Additional routing rule type
    Updates to groupe_instructeur.rb have enabled routing rules of the type Logic::NotEq, introducing an additional layer of rule management complexity.

  • Logic Testing
    A new context has been added to routing_engine_spec.rb for testing routing rules specifically of Logic::NotEq type with a non-equal rule, ensuring the efficient functioning of this added complexity.

@E-L-T E-L-T force-pushed the can-route-with-not-equals-routing-rules branch 2 times, most recently from c2020c6 to b57ef87 Compare August 29, 2023 20:44
Base automatically changed from can-route-from-departements-champ to main August 30, 2023 08:20
@E-L-T E-L-T force-pushed the can-route-with-not-equals-routing-rules branch 4 times, most recently from 1e29f6d to c6891d0 Compare September 4, 2023 13:34
@E-L-T E-L-T marked this pull request as ready for review September 4, 2023 15:19
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ma que bella, une proposition de refacto si ça te plait.

app/models/groupe_instructeur.rb Show resolved Hide resolved
@E-L-T E-L-T force-pushed the can-route-with-not-equals-routing-rules branch 3 times, most recently from 0004c25 to 25337e7 Compare September 5, 2023 13:45
@E-L-T E-L-T force-pushed the can-route-with-not-equals-routing-rules branch from 25337e7 to 32b446d Compare September 5, 2023 13:59
@E-L-T E-L-T added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 0c004fd Sep 6, 2023
@E-L-T E-L-T deleted the can-route-with-not-equals-routing-rules branch September 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETQ admin je peux choisir une règle de routage avec l'opérateur "n'est pas"
2 participants