Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur: fix flaky test et tri des dossiers par avis #9426

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

colinux
Copy link
Member

@colinux colinux commented Aug 29, 2023

Dans l'affichage des dossiers, on mélangeait les colonnes answer et question_answer (oui/non), ce qui occasionnait un flaky test car le test ne triait pas sur la bonne colonne.

Cette PR clarifie l'usage :

  • la colonne "answer" n'est pas exposée (pas visible dans le tableau, et donc pas dans les filtres). Elle avait été rendue filtrable par erreur en mai
  • la colonne "question_answer" est affichable (et a donc besoin d'être triable pour pas casser l'UI, même si pas idéal). En revanche elle n'est pas filtrable (pour le moment)

Conditionnel-·-demarches-simplifiees-fr

@LeSim LeSim added this pull request to the merge queue Aug 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2023
@colinux colinux added this pull request to the merge queue Aug 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2023
@colinux colinux added this pull request to the merge queue Aug 30, 2023
Merged via the queue into demarches-simplifiees:main with commit c4a54fc Aug 30, 2023
@colinux colinux deleted the fix-avis-answer-sort branch August 30, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants