ETQ instructeur: nouveau filigrane des titres d'identité qui améliore la lisibilité des images #9470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinux
force-pushed
the
improve-watermark
branch
9 times, most recently
from
5072967 to
ea29371
Compare
LeSim
approved these changes
Sep 12, 2023
|
|
||
| desc "Watermark demo. Usage: noglob rake pjs:watermark_demo[tmp/carte-identite-demo-1.jpg]" | ||
| task :watermark_demo, [:file_path] => :environment do |_t, args| | ||
| file = Pathname.new(args[:file_path]) |
There was a problem hiding this comment.
Suggested change
| file = Pathname.new(args[:file_path]) | |
| file = File.new(args[:file_path]) |
There was a problem hiding this comment.
J'ai gardé Pathname car pour ce qu'on en fait l'API est la même, et c'est beaucoup plus intuitif pour manipuler les extensions ici
colinux
force-pushed
the
improve-watermark
branch
2 times, most recently
from
7604969 to
e8104e7
Compare
colinux
force-pushed
the
improve-watermark
branch
from
e8104e7 to
6520ea0
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WATERMARK_FILEpour utiliserAPPLICATION_NAMEà la place. La variable d'envWATERMARK_FILEet son fichier peuvent être supprimés.Closes #9232
Exemples sur spécimens :
watermark-demo.mp4
AVANT