correctif(dsfr.burger-menu): le burger menu du DSFR n'aime pas le double dans le header #9476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinux
reviewed
Sep 12, 2023
…ble dans le header
mfo
force-pushed
the
US/fix-dsfr-burger-menu
branch
from
e0fe634 to
6046c98
Compare
colinux
approved these changes
Sep 12, 2023
les joies de patch-package. merci ! c'est corrigé |
colinux
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Avec la suppression du return prématuré if (toolsHtmlDuplicateId === menuHtml) return; je me demande si c'est pas signe qu'il y a des situations où ça pourrait être appelé 2x, et donc on le suffixerait plusieurs fois. Mais dur à dire, et même pas sûr que ce soit un problème d'ailleurs
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On peut pas deplier le menu pour changer de profil sur mobile (enfait, en vue small screen).
cf: GouvernementFR/dsfr#789