Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amelioration(agent-connect): tous les agents peuvent s'agent connecté #9480

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Sep 15, 2023

issue: #9481
figma: https://www.figma.com/proto/YKcafywdYhT6ABFlmy5d56/Am%C3%A9lioration-vue-usagers?node-id=2167-103808&starting-point-node-id=2111%3A92676

bonus:
les boutons de connexion en 100% de largueur à la DSFR, cf: https://www.systeme-de-design.gouv.fr/elements-d-interface/modeles/page-de-connexion

page de connexion instructeur avant:

Screenshot 2023-09-15 at 17-39-04 S’identifier avec AgentConnect · demarches-simplifiees fr

page de connexion instructeur apres:

Screenshot 2023-09-15 at 17-39-32 Se connecter avec AgentConnect · demarches-simplifiees fr

@mfo mfo force-pushed the US/enhance-agent-connect branch from 48734ce to b9981aa Compare September 15, 2023 15:38
Martin added 2 commits September 15, 2023 17:42
…ttes ainsi que change le message comme quoi la feature est dispo pour tous
…s en pleinne largueur sur les page de connexion/creation de compte
@mfo mfo force-pushed the US/enhance-agent-connect branch from b9981aa to 5cd5bcd Compare September 15, 2023 15:42
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je te file aussi le nouveau layout des colonnes pour qu'ils aient un truc propre et responsive sur lequel ils pourront itérer dessus ensuite

Par contre le bouton FranceConnect/AgentConnect on est pas censé le mettre en pleine largeur mais j'ai pas vu ce qui le mettait à 100%

app/views/agent_connect/agent/index.html.haml Outdated Show resolved Hide resolved
app/views/agent_connect/agent/index.html.haml Outdated Show resolved Hide resolved
app/views/agent_connect/agent/index.html.haml Outdated Show resolved Hide resolved
config/locales/views/agent_connect/agent/fr.yml Outdated Show resolved Hide resolved
@mfo
Copy link
Contributor Author

mfo commented Sep 18, 2023

je te file aussi le nouveau layout des colonnes pour qu'ils aient un truc propre et responsive sur lequel ils pourront itérer dessus ensuite

Par contre le bouton FranceConnect/AgentConnect on est pas censé le mettre en pleine largeur mais j'ai pas vu ce qui le mettait à 100%

yeap, je me suis mal exprimé. j'ai mis en pleinne largueur les boutons en bas, et laissé FranceConnect/AgentConnect à la chartre des boutons

tx pr le layout/colonne!

…tConnect ds le mail d'invitation des instructeurs

Update app/views/agent_connect/agent/index.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/agent_connect/agent/index.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/agent_connect/agent/index.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update config/locales/views/agent_connect/agent/fr.yml

Co-authored-by: Colin Darie <colin@darie.eu>
@mfo mfo force-pushed the US/enhance-agent-connect branch from 0c22904 to d203ab2 Compare September 18, 2023 07:48
@mfo mfo enabled auto-merge September 18, 2023 07:49
@mfo mfo added this pull request to the merge queue Sep 18, 2023
@colinux
Copy link
Member

colinux commented Sep 18, 2023

@mfo ah déso j'ai cru voir dans le mockup qu'il avait bougé aussi (mal réveillé?)

Merged via the queue into demarches-simplifiees:main with commit eee486c Sep 18, 2023
@mfo mfo deleted the US/enhance-agent-connect branch September 18, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants