Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ouidou/admin creation delegation gestionnaire page gestionnaire management #9538

Conversation

seb-by-ouidou
Copy link
Contributor

@seb-by-ouidou seb-by-ouidou commented Sep 28, 2023

#9111
ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - USER STORIES

ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - LOT 2 de DEV

liste des groupes gestionnaire
Screenshot 2023-10-04 at 19-35-08 demarches-simplifiees syn

show groupe gestionnaire
Screenshot 2023-10-04 at 19-35-45 demarches-simplifiees syn

manage gestionnaires of groupes gestionnaire
Screenshot 2023-10-04 at 19-37-08 demarches-simplifiees syn

US 4.3.7.1 bouton ajouter un gestionnaire
US 4.3.7.2 bouton supprimer un gestionnaire (pour ce groupe uniquement. si il est gestionnaire d'un seul groupe on lui supprimer son rôle de gestionnaire)


trackingAdullactContrib trackingAdullactARNiaContrib

@seb-by-ouidou seb-by-ouidou force-pushed the feature-ouidou/admin_creation_delegation_gestionnaire_page_gestionnaire_management branch 2 times, most recently from 752b35a to d91347d Compare October 4, 2023 17:40
@seb-by-ouidou seb-by-ouidou marked this pull request as ready for review October 5, 2023 15:03
@seb-by-ouidou
Copy link
Contributor Author

seb-by-ouidou commented Oct 5, 2023

@krichtof ; @tchak ready for review

@seb-by-ouidou seb-by-ouidou force-pushed the feature-ouidou/admin_creation_delegation_gestionnaire_page_gestionnaire_management branch 3 times, most recently from 9785216 to d395ed6 Compare October 10, 2023 09:50
@tchak
Copy link
Member

tchak commented Oct 10, 2023

@seb-by-ouidou les tests sur rspec ./spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb ne passent pas chez moi

@seb-by-ouidou
Copy link
Contributor Author

seb-by-ouidou commented Oct 10, 2023

@tchak tu pourrais me dire quelles erreurs tu as et tous les info possible car chez moi pas de pb


$ bundle exec rspec ./spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb
Running via Spring preloader in process 33
Run options:
  include {:focus=>true}
  exclude {:disable=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 36959
.....

Top 5 slowest examples (0.30769 seconds, 98.7% of total time):
  Gestionnaires::GroupeGestionnairesController#index when logged in is expected to include #<GroupeGestionnaire id: 1, created_at: "2023-10-10 15:55:08.319925000 +0200", groupe_gestionnaire_id: nil, name: "Group 1", updated_at: "2023-10-10 15:55:08.319925000 +0200">
    0.1317 seconds ./spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb:22
  Gestionnaires::GroupeGestionnairesController#index when logged in is expected to include #<GroupeGestionnaire id: 8, created_at: "2023-10-10 15:55:08.448463000 +0200", groupe_gestionnaire_id: nil, name: "Group 8", updated_at: "2023-10-10 15:55:08.448463000 +0200">
    0.05716 seconds ./spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb:23
  Gestionnaires::GroupeGestionnairesController#index when logged in is expected to respond with status code :ok (200)
    0.0571 seconds ./spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb:21
  Gestionnaires::GroupeGestionnairesController#index when logged in is expected not to include #<GroupeGestionnaire id: 6, created_at: "2023-10-10 15:55:08.408329000 +0200", groupe_gestionnaire_id: nil, name: "Group 6", updated_at: "2023-10-10 15:55:08.408329000 +0200">
    0.04502 seconds ./spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb:24
  Gestionnaires::GroupeGestionnairesController#index when not logged is expected to redirect to "/users/sign_in"
    0.01671 seconds ./spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb:9

Finished in 0.31172 seconds (files took 7.84 seconds to load)
5 examples, 0 failures

Randomized with seed 36959


@tchak
Copy link
Member

tchak commented Oct 10, 2023

@seb-by-ouidou mêmes erreurs que sur la CI

@seb-by-ouidou seb-by-ouidou force-pushed the feature-ouidou/admin_creation_delegation_gestionnaire_page_gestionnaire_management branch from d395ed6 to c7eecb9 Compare October 10, 2023 16:47
@seb-by-ouidou
Copy link
Contributor Author

@tchak fixed: l'erreur venait de la variable ENV['ADMINS_GROUP_ENABLED'] non presente sur les tests

@seb-by-ouidou seb-by-ouidou force-pushed the feature-ouidou/admin_creation_delegation_gestionnaire_page_gestionnaire_management branch from 4806054 to 124a2bd Compare October 11, 2023 07:38
@tchak tchak added this pull request to the merge queue Oct 11, 2023
@tchak tchak removed this pull request from the merge queue due to a manual request Oct 11, 2023
@seb-by-ouidou seb-by-ouidou force-pushed the feature-ouidou/admin_creation_delegation_gestionnaire_page_gestionnaire_management branch from 124a2bd to 8b1a14e Compare October 11, 2023 13:17
@tchak tchak added this pull request to the merge queue Oct 11, 2023
Merged via the queue into demarches-simplifiees:main with commit 7f1bddf Oct 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants