Feature ouidou/admin creation delegation gestionnaire page children management #9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_page_children_management
branch
from
1d454c3 to
528c51c
Compare
|
Il y a plusieurs tests unitaires qui ne passent pas. |
|
@krichtof etrangement il ne joue pas la migration avant le test. aurais tu une idee de pourquoi ? je vais aussi degarder de mon coté |
|
@seb-by-ouidou Je crois que tu as oublié de commiter |
|
@krichtof fixed |
krichtof
reviewed
Oct 26, 2023
krichtof
reviewed
Nov 8, 2023
| gestionnaire = Gestionnaire.find(params[:id]) | ||
|
|
||
| if !gestionnaire.can_be_deleted? | ||
| fail "Impossible de supprimer ce gestionnaire car il est gestionnaire d'un groupe racine" |
There was a problem hiding this comment.
Peux-tu plutôt utiliser flash[:alert] ?
(je crois qu'on utilise fail une ou deux fois dans le manager mais nous allons également le corriger)
| belongs_to :groupe_gestionnaire, optional: true # parent | ||
| has_many :children, class_name: "GroupeGestionnaire", inverse_of: :groupe_gestionnaire | ||
| # belongs_to :groupe_gestionnaire, optional: true # parent | ||
| # has_many :children, class_name: "GroupeGestionnaire", inverse_of: :groupe_gestionnaire | ||
| has_many :administrateurs |
There was a problem hiding this comment.
Peux-tu du coup supprimer ces 2 lignes plutôt que de les laisser en commentaire ?
krichtof
approved these changes
Nov 8, 2023
Merged
via the queue into
demarches-simplifiees:main
with commit Nov 8, 2023
a6ea607
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9111
ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - USER STORIES
ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - LOT 2 de DEV
add children group
