Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remonte les erreurs dans Sentry lorsqu'un appel webhook est en erreur #9573

Merged
merged 1 commit into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/jobs/web_hook_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@ def perform(procedure_id, dossier_id, state, updated_at)
state: state,
updated_at: updated_at
}

procedure = Procedure.find(procedure_id)
Typhoeus.post(procedure.web_hook_url, body: body, timeout: TIMEOUT)

response = Typhoeus.post(procedure.web_hook_url, body: body, timeout: TIMEOUT)

if !response.success?
Sentry.set_tags(procedure: procedure_id, dossier: dossier_id)
Sentry.set_extras(web_hook_url: procedure.web_hook_url)
Sentry.capture_message("Webhook error: #{response.status} // Response: #{response.body}")
end
end
end
22 changes: 22 additions & 0 deletions spec/jobs/web_hook_job_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
describe WebHookJob, type: :job do
describe 'perform' do
let(:procedure) { create(:procedure, web_hook_url:) }
let(:dossier) { create(:dossier, procedure:) }
let(:web_hook_url) { "https://domaine.fr/callback_url" }
let(:job) { WebHookJob.new(procedure.id, dossier.id, dossier.state, dossier.updated_at) }

context 'with success on webhook' do
it 'calls webhook' do
stub_request(:post, web_hook_url).to_return(status: 200, body: "success")
expect { job.perform_now }.not_to raise_error
end
end

context 'with error on webhook' do
it 'raises' do
stub_request(:post, web_hook_url).to_return(status: 500, body: "error")
expect { job.perform_now }.to raise_error
end
end
end
end