correctif(tech.export): il arrive que des exports soient mal identifié (le content-type), ce qui par la suite renvoie des exports vide (0kb) #9582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2023 10:39
…is a 0 [mauvais identification due au type de contenu]
…identifie [content_type] est identified, pas identify
mfo
force-pushed
the
US/fix-export-job
branch
from
45648bc to
f4430ce
Compare
mfo
changed the title
LeSim
approved these changes
Oct 10, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c'est un peu le bazard ces api active storage. apres avoir creusé la codebase de rails, l'impression que :
identify: false(ex: https://api.rubyonrails.org/classes/ActiveStorage/Blob.html#method-c-create_and_upload-21)metadata[:identified]=true(ex: https://api.rubyonrails.org/classes/ActiveStorage/Blob.html#method-c-create_before_direct_upload-21)aussi, l'attribute pour verifier si il faut inferer le content_type (donc via le identifiable) est stocké sur le metadata nommé
identified: https://github.com/rails/rails/blob/main/activestorage/app/models/active_storage/blob.rb#L29mon impression est que la difference entre
identify, c'est un paramêtre "transiant" qui vient a etre repliqué sur le metadata en fin de cycle.metadata[:identified]car le cycle de vie de l'upload est different