correctif(data): tâche rake recréant les champs manquant à un dossier ayant subi une perte de données #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… des dossiers qui ont subit une perte de donnée supposant qu'une race-condition sur le dossier.merge(fork) puisse detruire des champs
mfo
force-pushed
the
US/fix-missing-champs
branch
from
1566d93 to
8069c5b
Compare
added 3 commits
October 16, 2023 17:19
…ake pour corriger les données de prod
…manquant a un dossier
… aux fix de data en prod
mfo
force-pushed
the
US/fix-missing-champs
branch
from
95bdcc9 to
4e4b7b5
Compare
mfo
added
bug
a-communiquer
Co-authored-by: Colin Darie <colin@darie.eu>
mfo
force-pushed
the
US/fix-missing-champs
branch
from
4e4b7b5 to
2879c27
Compare
colinux
approved these changes
Oct 18, 2023
colinux
changed the title
mfo
force-pushed
the
US/fix-missing-champs
branch
from
f79dac8 to
077dffb
Compare
…les champs manquant dans une repetition
mfo
force-pushed
the
US/fix-missing-champs
branch
from
077dffb to
70c5480
Compare
mfo
force-pushed
the
US/fix-missing-champs
branch
from
0e958ac to
ec2e03f
Compare
colinux
approved these changes
Oct 19, 2023
Merged
via the queue into
demarches-simplifiees:main
with commit Oct 19, 2023
8a4299a
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contexte
un instructeur / admin sur DS nous a remonté qu'un champ c'était fait la mal sur un dossier.
après investigation, les pointeurs laissent à croire que le problème viendrait d'un probleme de "race condition" arrivant par un double submit lorsqu'un usager depose son dossier. Donc ça se passerait autour de
Users::DossiersController#submit_en_construction, plus précisementediting_fork_origin = @dossier.editing_fork_origin && editing_fork_origin.merge_fork(@dossier)qui peuvent enclancher de grosses transaction SQL.solution
pour le moment on essaie d'eviter le double submit par l'UI (le plus simple).
puis on va remettre les champs manquant en prod et s'outiller ainsi.
todo :