amelioration(dossier.pdf): pour les champs de type Champs::AddressChamp, ajoute le code insee de la commune sous l'adresse complete #9624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfo
force-pushed
the
US/dossier.export.pdf
branch
from
7d169a8 to
e2beb93
Compare
tchak
reviewed
Oct 23, 2023
app/views/dossiers/show.pdf.prawn
Outdated
| when 'Champs::AddressChamp' | ||
| value = champ.blank? ? 'Non communiqué' : champ.to_s | ||
| format_in_2_lines(pdf, tdc.libelle, value) | ||
| format_in_2_lines(pdf, "Code INSEE :", champ.commune&.fetch(:code)) if champ.full_address? |
There was a problem hiding this comment.
Tu pourrais aussi en profiter pour ajouter le nom et le code du département ici, ainsi qu'au champ commune ?
mfo
force-pushed
the
US/dossier.export.pdf
branch
from
e2beb93 to
0520fb4
Compare
…mp, ajoute le code insee de la commune sous l'adresse complete, ajoute le code postal, ajoute le departemenent et son code. Pour les champs de type Champs::CommuneChamp ajoute le code postal de la commune
mfo
force-pushed
the
US/dossier.export.pdf
branch
from
0520fb4 to
2295d64
Compare
tchak
approved these changes
Oct 25, 2023
Merged
via the queue into
demarches-simplifiees:main
with commit Oct 26, 2023
9866acc
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hs: https://secure.helpscout.net/conversation/2293515574/2034524