Feature ouidou/admin creation delegation gestionnaire answer administrateur #9645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
branch
from
1ee8413 to
8968000
Compare
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
branch
from
8968000 to
ec89f47
Compare
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
branch
from
ec89f47 to
562a52a
Compare
colinux
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Hello, on a détaillé dans la PR, dans le fond on préfère favoriser la réutilisation et adaptation de code qu'on a déjà plutôt que dupliquer (et surtout maintenir) du nouveau code assez proche dans l'esprit. On parle plus spécifiquement du MessageComponent.
Dispo si nécessaire
cc @krichtof
...naire/groupe_gestionnaire_commentaires/commentaire_component/commentaire_component.html.haml
Outdated
Show resolved
Hide resolved
app/views/gestionnaires/groupe_gestionnaire_commentaires/index.html.haml
Show resolved
Hide resolved
app/views/gestionnaires/groupe_gestionnaire_commentaires/index.html.haml
Show resolved
Hide resolved
app/controllers/gestionnaires/groupe_gestionnaire_commentaires_controller.rb
Show resolved
Hide resolved
app/views/shared/groupe_gestionnaires/commentaires/_form.html.haml
Outdated
Show resolved
Hide resolved
spec/controllers/gestionnaires/groupe_gestionnaire_commentaires_controller_spec.rb
Show resolved
Hide resolved
spec/controllers/gestionnaires/groupe_gestionnaire_commentaires_controller_spec.rb
Show resolved
Hide resolved
spec/controllers/gestionnaires/groupe_gestionnaire_commentaires_controller_spec.rb
Show resolved
Hide resolved
spec/controllers/gestionnaires/groupe_gestionnaire_commentaires_controller_spec.rb
Show resolved
Hide resolved
|
toutes les modifications demandées ont eté effectuées. Comme cela concernait aussi les prochaines PR en attente qui arriverons ensuite , j'ai créé une nouvelle PR qui part de la derniere des PR qui sont en attente
|
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
branch
2 times, most recently
from
abca82d to
cdc3529
Compare
added 7 commits
January 22, 2024 14:36
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
branch
from
cdc3529 to
0bb189d
Compare
Merged
via the queue into
demarches-simplifiees:main
with commit Jan 22, 2024
716e4bb
16 checks passed
colinux
deleted the
feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9111
ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - USER STORIES
ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - LOT 3 de DEV
US 5.2.2 contacter mon/mes gestionnaires de groupe via un formulaire