Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

En tant qu'admin, je peux filtrer les démarches par département #9649

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

krichtof
Copy link
Contributor

close #9642

NE PAS MERGER

Avant de merger cette PR, il faut au préalable que #9647 ait été déployée et que la tâche BackfillDepartementServices ait été lancée

Ce que fait cette PR

Cette PR permet de filtrer les démarches à partir du département du service qui opère cette démarche.

2023-10-27-103912_1245x665_scrot

@what-the-diff
Copy link

what-the-diff bot commented Oct 27, 2023

PR Summary

  • Enhanced Procedure Management in Controller
    A new variable named services has been integrated into the procedures controller. The addition of this new variable helps in precisely managing and controlling various procedures in the system.

  • Dynamic Department Update
    We have incorporated a mechanism where the 'Department' field gets automatically updated depending on the locale code within the service job file. This functionality leads to more accuracy and up-to-date information in the department data.

  • Filtering Capability Introduced for Service Department
    A new parameter service_departement has been introduced into the procedures filter. This enables users to have more versatility in filtering procedures based on the specific department.

  • Display and Filtering by Service Department
    The main display file has been updated to show the 'service department' and also to filter by it. This would help users to immediately see the department involved while also enabling them to sort the displayed items as per their needs.

  • Testing for Filtering Procedures
    A new test case for the feature to filter procedures based on a specific department has been added. This will ensure the feature performs as expected under different scenarios.

  • Department Update Testing
    A new test case has been developed to verify the department updating functionality in the service job. This guarantees that the system accurately updates departmental information as per the given locale code.

Département
.fr-ml-1w.hidden{ 'data-expand-target': 'content' }
%div
= f.text_field :service_departement, placeholder: 'Indiquez le n° du département', class: 'fr-input'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux en faire un select, s'il te plaît ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
J'ai rebasé le commit pour utiliser le select.

Copy link
Member

@tchak tchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La sélection de département doit se faire via un select.

Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
@krichtof krichtof added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 0daeca1 Oct 30, 2023
15 checks passed
@krichtof krichtof deleted the 9642-filter-dept branch October 30, 2023 09:25
@colinux
Copy link
Member

colinux commented Oct 30, 2023

@krichtof est ce que ce serait pas une bonne idée de commenter rapidement dans les releases concernées ce qu'il faut faire avant que les instances déploient ça?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etq admin, je peux filtrer toutes les demarches par departement du service (si le siret est renseigné)
3 participants