Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usager: fix alignement du champ "autre" des listes de choix #9652

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Oct 30, 2023

APRES

Capture d’écran 2023-10-30 à 10 58 26

AVANT

Capture d’écran 2023-10-30 à 11 06 28

@what-the-diff
Copy link

what-the-diff bot commented Oct 30, 2023

PR Summary

  • Implement new methods in EditableChamp::DropDownListComponent
    The team has included new functionalities to the Drop Down List component. This includes a method to determine if it should render and another to specify additional class names.

  • Haml file refactoring
    Several enhancements were made to the haml file code. This includes adjusting code indentation, improving conditional statements, and removing an unnecessary hyphen.

  • Code for component rendering
    There is an addition of a new line of code that will enable the component to be rendered based on certain conditions.

  • Select tag improvement
    Changes have been made to the "select" tag in the haml file. This involves adjusting code indentation and adding important attributes for accessibility and input requirement.

  • New element addition
    A new div element was included with a class "fr-fieldset__element" to help with the form structure on the page.

  • Addition of new component
    A new component named "EditableChamp::DropDownOtherInputComponent" has been added. This allows for more complex and interactive drop-down menu options.

@colinux colinux added this pull request to the merge queue Oct 30, 2023
Merged via the queue into demarches-simplifiees:main with commit 8c6489f Oct 30, 2023
15 checks passed
@colinux colinux deleted the fix-dropdown-other-markup branch October 30, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants