Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ETQ admin, je souhaite associer une démarche existante depuis le bouton "clore" du tableau de bord de la démarche #9653

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

lisa-durand
Copy link
Contributor

closes #9593

Le bouton du tableau de bord ne clot plus directement la démarche mais redirige vers une page (déjà existante) pour cloturer la démarche et ainsi ajouter un lien vers une démarche existante si besoin.

J'en ai profité pour retirer l'ancien style de card et fixer le breadcrumb.

Capture d’écran 2023-10-30 à 14 59 58

@what-the-diff
Copy link

what-the-diff bot commented Oct 30, 2023

PR Summary

  • New Instance Variable Addition
    A new variable called 'published_procedures' has been added in the procedure controller. This helps manage better the procedures which are currently published.

  • Form UI Update
    The user interface for administrators has been updated to include a new dropdown menu for 'new_procedure'. This change will provide more options to administrators for procedure management. At the same time, the design of the submit button has been improved for better user experience.

  • Link Modification
    In a page displaying procedure details, the requirement for confirmation before closing a procedure has been removed. This will make the process faster and less repetitive for users.

  • Translation Additions
    Language support has been broadened with new translations added for 'new_procedure' and for 'page_title' in the procedure-closing interface. This will help ensure that administrators, regardless of their language preference, will understand the options and process more clearly. The languages updated with these translations are English and French.

@lisa-durand lisa-durand marked this pull request as ready for review October 31, 2023 10:25

%p= t('administrateurs.procedures.close.replacement_procedure_title')

= form_tag admin_procedure_archive_path(@procedure), method: :put, class: "form" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je pense que le class: form n'est plus utile ? (on pourra virer plein de css quand on aura plus aucun form avec cette classe !)

@@ -316,6 +316,7 @@ def transfert
end

def close
@published_procedures = current_administrateur.procedures.publiees.map { |p| ["#{p.libelle} (#{p.id})", p.id] }.to_h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@published_procedures = current_administrateur.procedures.publiees.map { |p| ["#{p.libelle} (#{p.id})", p.id] }.to_h
@published_procedures = current_administrateur.procedures.publiees.to_h { |p| ["#{p.libelle} (#{p.id})", p.id] }

@lisa-durand lisa-durand requested a review from colinux November 6, 2023 10:23
@lisa-durand lisa-durand added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit baaf4e3 Nov 6, 2023
15 checks passed
@lisa-durand lisa-durand deleted the fix-close-procedure-page branch November 6, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants