Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctif(pdf): ETQ instructeur, lorsque je télécharge un dossier et ses PJs, les \t deviennent des ? #9656

Merged

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Oct 31, 2023

@mfo mfo force-pushed the US/fix-non-printable-char-in-pdf branch from df1986d to 966c7a2 Compare October 31, 2023 10:22
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a déjà la méthode clean_string qui fait ça à plein d'autres endroits, tu voudrais pas l'utiliser à la place?

@mfo
Copy link
Contributor Author

mfo commented Oct 31, 2023

suite a un echange ac colin, on préfère aller dans le sens du each_line et continuer l'idée du [[:space:]].

affaire à suivre si on retombe sur des ?

__
nop, elle bouffe les retours a la ligne. cf: https://ruby-doc.org/3.2.2/Regexp.html
/[[:space:]]/ - Whitespace character ([:blank:], newline, carriage return, etc.)

que penses-tu de remplacer par ?
/[[:blank:]]/ - Space or tab

@mfo mfo force-pushed the US/fix-non-printable-char-in-pdf branch 3 times, most recently from 9e170e7 to c075797 Compare October 31, 2023 16:04
…ses PJs, les \t deviennent des ?

Co-authored-by: colin@darie.eu
@mfo mfo force-pushed the US/fix-non-printable-char-in-pdf branch from c075797 to 25a4a4d Compare October 31, 2023 16:05
@mfo mfo enabled auto-merge October 31, 2023 16:07
@mfo mfo added this pull request to the merge queue Oct 31, 2023
Merged via the queue into demarches-simplifiees:main with commit 0e2d973 Oct 31, 2023
15 checks passed
@mfo mfo deleted the US/fix-non-printable-char-in-pdf branch October 31, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants