Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctif(dossiers): ETQ usager, le menu d'invitation etait cassé sur mobile #9700

Merged
merged 1 commit into from
Nov 14, 2023
Merged

correctif(dossiers): ETQ usager, le menu d'invitation etait cassé sur mobile #9700

merged 1 commit into from
Nov 14, 2023

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Nov 13, 2023 •
edited
Loading

avant :
Screenshot 2023-11-13 at 10 36 11 AM

apres :
alignement des boutons

Screenshot 2023-11-13 at 11 29 28 AM

positionnement de la modal ok :

Screenshot 2023-11-13 at 11 27 25 AM

PS: je pense que l'idéal serait de

  1. virer les dropdown/modal (une galere a maintenir, a11y etc...), de l'inconsistance sur mobile, c'est pas tres utilisable je trouve
  2. creer la page gestion des invitations et utiliser un lien bete et mechant (au moins c'est fiable)
  3. utiliser la page gestion de l'identité plutot que la dropdown/modal

@mfo mfo changed the title correctif(dossiers): ETQ usager, le menu d'invitation etait cassé sur… correctif(dossiers): ETQ usager, le menu d'invitation etait cassé sur mobile Nov 13, 2023
colinux
colinux approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour la vision long terme / page dédiée pour ce cas là

@mfo mfo force-pushed the US/fix-invite-modal branch 2 times, most recently from 5632fda to b072ea3 Compare November 13, 2023 10:54
@mfo mfo enabled auto-merge November 13, 2023 10:55
@mfo mfo force-pushed the US/fix-invite-modal branch 2 times, most recently from 08b24ae to c843952 Compare November 13, 2023 15:21
@mfo mfo force-pushed the US/fix-invite-modal branch from c843952 to c1a4f7d Compare November 14, 2023 08:22
@mfo mfo added this pull request to the merge queue Nov 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2023
@colinux colinux added this pull request to the merge queue Nov 14, 2023
Merged via the queue into demarches-simplifiees:main with commit da6e5fc Nov 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinux colinux colinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfo @colinux