Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre #9754

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

krichtof
Copy link
Contributor

close #9435

  • Dans le manager, depuis la page d'un dossier, il est possible de transférer un dossier :

2023-11-28-095730_836x117_scrot

  • Une page spécifique pour le transfert d'un dossier s'affiche alors :

2023-11-28-101504_665x534_scrot

  • L'utilisateur cible peut accepter ou rejeter la demande, et il lui est indiqué qu'elle a été initiée par le support technique :

2023-11-28-100352_796x433_scrot

  • le superadmin peut révoquer la demande depuis la page dossier :

2023-11-28-100433_828x186_scrot

Copy link

what-the-diff bot commented Nov 28, 2023

PR Summary

  • Addition of new methods in the manager's controller
    New functionalities have been added to the dossier management system. It is now possible to make transfer operations such as editing, creating and deleting a transfer through new methods transfer_edit, transfer and transfer_destroy.

  • New attribute in the Dossier model
    A new attribute from_support has been added in the dossier model. It provides additional details about the transfer operation.

  • UI updates for Dossier Show View
    The interface for viewing individual dossiers now has a link for transferring the dossier and a conditional message display. The message display system takes into account the dossier.transfer.from_support attribute to give users relevant information.

  • New Dossier Transfer Edit View
    A new view for editing transfers has been created. This makes edits/changes to transfer details much easier to achieve.

  • Updates to the Dossier List View
    The dossier list view is now smarter and can show different messages based on the state of the dossier.transfer.from_support attribute. All these messages are localized for better international support.

  • Addition of Localization for new messages
    Translatable text for all newly added messages has been added in both English and French language files.

  • Enhancement of Routing system
    Routes for the new transfer methods transfer_edit, transfer, and transfer_destroy have been added. This makes accessing these new features simpler and efficient.

  • Database Schema Adjustments
    The database has been updated with new from_support columns in the dossier_transfers and dossier_transfer_logs tables. This makes logging and tracking of transfer operations more detailed.

  • Updated Test Suite
    New tests have been added to ensure that the new transfer and transfer_destroy operations work as expected, which greatly contributes toward the stability and robustness of the application.

@krichtof krichtof force-pushed the 9435-transfer-dossier branch 2 times, most recently from fc74367 to 220f983 Compare November 28, 2023 09:51
@krichtof krichtof changed the title En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre NE PAS REVIEWER - En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre Nov 28, 2023
@krichtof krichtof force-pushed the 9435-transfer-dossier branch from 220f983 to 37722e8 Compare November 28, 2023 11:26
@krichtof krichtof force-pushed the 9435-transfer-dossier branch from 37722e8 to ff6ed60 Compare November 28, 2023 14:48
@krichtof krichtof changed the title NE PAS REVIEWER - En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre Nov 28, 2023
@krichtof krichtof marked this pull request as ready for review November 28, 2023 15:18
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo html, sinon well done !

@@ -68,15 +68,21 @@
= render Dsfr::AlertComponent.new(state: :info, size: :sm) do |c|
- c.body do
%p
= t('views.users.dossiers.transfers.receiver_demande_en_cours', id: dossier.id, email: dossier.user.email)
- if dossier.transfer.from_support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste pour info : rails permet de faire .from_support? sur les attributs booléens

@@ -36,6 +36,14 @@ as well as a link to its edit page.
</header>

<section class="main-content__body">
<div>
<% if dossier.transfer&.from_support %>
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ce <p> n'est pas refermé

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasé et intégré

@krichtof krichtof force-pushed the 9435-transfer-dossier branch from ff6ed60 to 122a6b6 Compare December 12, 2023 14:25
@krichtof krichtof enabled auto-merge December 12, 2023 14:27
@krichtof krichtof added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 246d53f Dec 12, 2023
16 checks passed
@krichtof krichtof deleted the 9435-transfer-dossier branch December 12, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETQ super manager, je veux pouvoir transférer un dossier d'un usager à l'autre
2 participants