Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature ouidou/batch action on dossiers repousser date suppression #9772

Merged
merged 6 commits into from
Dec 9, 2023
Merged

Feature ouidou/batch action on dossiers repousser date suppression #9772

merged 6 commits into from
Dec 9, 2023

Conversation

seb-by-ouidou
Copy link
Contributor

#7805

batch action pour repousser la date d'expiration de dossiers depuis l'onglet expirant
Screenshot 2023-11-30 at 15-46-18 test 1 · demarches-simplifiees syn
Screenshot 2023-11-30 at 15-46-56 test 1 · demarches-simplifiees syn
Screenshot 2023-11-30 at 15-47-18 test 1 · demarches-simplifiees syn

trackingAdullactContrib trackingAdullactARNiaContrib

@dzc34 dzc34 mentioned this pull request Dec 5, 2023
Closed
mfo
mfo approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK sur l'expiration, juste un petit bout de code que tu peux virer qui ne servira pas

app/components/dossiers/batch_operation_component.rb Outdated Show resolved Hide resolved
mfo
mfo approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@mfo mfo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autre remarque sur les dossiers en brouillon qui ne concernent pas les instructeurs

app/models/batch_operation.rb Outdated Show resolved Hide resolved
@dzc34
Copy link
Collaborator

dzc34 commented Dec 5, 2023

je rajoute un peu de contexte :

Chacune des PR "actions multiples" inclus les commits des autres PR,
car le code pour chacune des PR se trouve au même endroit.
Sans faire cela, cela créerait des conflits après la validation de chaque PR.

Donc 2 solutions :

Je vous laisse voir la solution que vous préférez et reste dispo si besoin pour un échange sur ce sujet.

This was referenced Dec 5, 2023
Closed
Closed
Closed
Closed
@seb-by-ouidou seb-by-ouidou force-pushed the feature-ouidou/batch_action_on_dossiers_repousser_date_suppression branch from b92f085 to 56aecbb Compare December 6, 2023 13:50
lisa-durand
lisa-durand reviewed Dec 6, 2023
View reviewed changes
app/components/dossiers/batch_operation_component.rb
{
label: t(".operations.desarchiver"),
operation: BatchOperation.operations.fetch(:desarchiver)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce possible de rajouter à peu de frais l'action "supprimer" pour avoir toutes les actions multiples disponibles sur cet onglet ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour moi pas de pb. en attente de confirmation de la dinum et de l'adullact

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le github me fait flipper avec toutes ces PR ouvertes, je lance un merge, tu pourras pusher ça ds une autre PR stp ?
merci pr le taff

@mfo mfo added this pull request to the merge queue Dec 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2023
@mfo mfo force-pushed the feature-ouidou/batch_action_on_dossiers_repousser_date_suppression branch from 13b9414 to 96adffb Compare December 9, 2023 05:27
@mfo mfo enabled auto-merge December 9, 2023 05:27
@mfo mfo added this pull request to the merge queue Dec 9, 2023
Merged via the queue into demarches-simplifiees:main with commit 417f70f Dec 9, 2023
15 checks passed
@mfo mfo deleted the feature-ouidou/batch_action_on_dossiers_repousser_date_suppression branch December 9, 2023 05:50
@dzc34
Copy link
Collaborator

dzc34 commented Dec 11, 2023

Merci à @mfo et @lisa-durand pour la relecture et le merge, et à @seb-by-ouidou pour ces nouvelles fonctionnalités et les correctifs pendant la phase de relecture.

Je viens de regarder sur l'instance de la DINUM : ces nouvelles actions multiples semble fonctionner comme prévu.

nota : nous avons noté les points évoqués par @mfo (nombre de PR ouverte, besoin de revert fonctionnalité par fonctionnalité, ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfo mfo mfo approved these changes

@lisa-durand lisa-durand lisa-durand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seb-by-ouidou @dzc34 @mfo @lisa-durand