Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETQ instructeur, lorsque je veux filtrer les dossiers d'une démarche, je peux utiliser un autocomplete #9820

Merged
merged 1 commit into from
Dec 11, 2023
Merged

ETQ instructeur, lorsque je veux filtrer les dossiers d'une démarche, je peux utiliser un autocomplete #9820

merged 1 commit into from
Dec 11, 2023

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Dec 7, 2023 •
edited
Loading

ezgif-3-283ecc6881

@mfo mfo force-pushed the US/filter-dossier-with-combobox branch 5 times, most recently from 551c344 to b64b137 Compare December 8, 2023 10:36
@mfo mfo force-pushed the US/filter-dossier-with-combobox branch from b64b137 to 1f13000 Compare December 8, 2023 15:10
@mfo mfo changed the title wip - Us/filter dossier with combobox ETQ instructeur, lorsque je veux filtrer les dossiers d'une démarche, je peux utiliser un autocomplete Dec 8, 2023
colinux
colinux approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

app/javascript/controllers/autosubmit_controller.ts
@@ -75,12 +76,19 @@ export class AutosubmitController extends ApplicationController {
}

private preventAutosubmit(
target: HTMLElement & { disabled?: boolean },
target: HTMLElement & { disabled?: boolean } & { value?: string },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marrant que t'es pas fait :

Suggested change
target: HTMLElement & { disabled?: boolean } & { value?: string },
target: HTMLElement & { disabled?: boolean; value?: string },

mais en vrai osef

@mfo mfo merged commit b56d519 into demarches-simplifiees:main Dec 11, 2023
15 checks passed
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 11, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to execute 'requestSubmit' on 'HTMLFormElement': parameter 1 is not of type 'HTMLElement'. {_AutosubmitController#2}.submit(app/javascript... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinux colinux colinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfo @colinux