Délégation de compte: ETQ gestionnaire je peux contacter les gestionnaires des groupes parents #9846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
branch
2 times, most recently
from
8aa0439 to
8bc9d46
Compare
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
branch
from
8bc9d46 to
1811383
Compare
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
branch
3 times, most recently
from
1811383 to
22e53e5
Compare
colinux
changed the title
colinux
reviewed
Feb 9, 2024
app/controllers/gestionnaires/groupe_gestionnaire_commentaires_controller.rb
Outdated
Show resolved
Hide resolved
| end | ||
|
|
||
| def create | ||
| @commentaire = @groupe_gestionnaire.commentaire_groupe_gestionnaires.create(commentaire_params.merge(sender_id: @last_commentaire.sender_id, sender_type: @last_commentaire.sender_type, gestionnaire: current_gestionnaire)) | ||
| @commentaire = @last_commentaire.groupe_gestionnaire.commentaire_groupe_gestionnaires.create(commentaire_params.merge(sender_id: @last_commentaire.sender_id, sender_type: @last_commentaire.sender_type, gestionnaire: current_gestionnaire)) |
There was a problem hiding this comment.
peut-être que ça passe pour être plus concis :
Suggested change
| @commentaire = @last_commentaire.groupe_gestionnaire.commentaire_groupe_gestionnaires.create(commentaire_params.merge(sender_id: @last_commentaire.sender_id, sender_type: @last_commentaire.sender_type, gestionnaire: current_gestionnaire)) | |
| @commentaire = @last_commentaire.groupe_gestionnaire.commentaire_groupe_gestionnaires.create(commentaire_params.merge(sender: @last_commentaire.sender, gestionnaire: current_gestionnaire)) |
app/controllers/gestionnaires/groupe_gestionnaire_commentaires_controller.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Beaucoup de logique compliquée dans le vue, y compris du SQL. Ce serait envisageable de remonter ça dans le controller,(ou à défaut dans le modèle ou component…) ?
There was a problem hiding this comment.
OK on a vu le fix dans la PR d'après !
app/views/gestionnaires/groupe_gestionnaire_commentaires/parent_groupe_gestionnaire.haml
Show resolved
Hide resolved
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
branch
from
22e53e5 to
f02c0da
Compare
seb-by-ouidou
force-pushed
the
feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
branch
from
d19ca25 to
08cffda
Compare
colinux
approved these changes
Feb 13, 2024
Merged
via the queue into
demarches-simplifiees:main
with commit Feb 13, 2024
48644ae
16 checks passed
colinux
deleted the
feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9111
ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - USER STORIES
ETQ super-admin, déléguer la création des comptes administrateurs à des "gestionnaires de groupe - LOT 5 de DEV
US 4.3.2.1 contacter les gestionnaires groupe parent par formulaire