Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin, quand je configure un type de champ regexp, j'ai une petite mention sur le bornage de celle ci #9875

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Dec 21, 2023

Screenshot 2023-12-21 at 9 41 37 AM

@mfo mfo changed the title feat(TypeDeChampEditor.regexp): add hint regarding regexp begin/finish ETQ admin, quand je configure un type de champ regexp, j'ai une petite mention sur le bornage de celle ci Dec 21, 2023
@mfo mfo enabled auto-merge December 21, 2023 08:28
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une proposition se basant sur un exemple.

@LeSim LeSim disabled auto-merge December 21, 2023 08:35
@@ -15,6 +15,7 @@ fr:
limit: Limité à %{limit} caractères
expression_reguliere:
labels:
regex: Saisissez votre expression régulière, essayez-la sur https://rubular.com
regex: Saisissez votre expression régulière, essayez-la sur https://rubular.com.
hint: "Pensez aux delimiteurs de début (^) et fin ($) : `12,3 km` est validé par `/[[:digit:]]*/` mais rejeté par `/^[[:digit:]]*$/`"
Copy link
Member

@colinux colinux Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ce ne sont pas des délimiteurs (qui sont les / ou # par exemple) mais des ancres

Sinon je trouve le sens de "valider" ambigu. On pourrait dire plus simplement 12 km serait accepté par /[[:digit:]]+/ mais rejeté par /^[[:digit:]]+$/ ?

Co-authored-by: LeSim <mail@simon.lehericey.net>
Co-authored-by: Colin Darie <colin@darie.eu>
@mfo mfo added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@mfo mfo added this pull request to the merge queue Dec 27, 2023
Merged via the queue into demarches-simplifiees:main with commit 002a141 Dec 27, 2023
15 checks passed
@mfo mfo deleted the US/hint-regexp branch December 27, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants