Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: fix le job de vérification des liens externes des procédures lorsqu'un autre attribut est en erreur #9946

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Jan 29, 2024

Vu sur delayed job et https://demarches-simplifiees.sentry.io/issues/4604375721/ sur des vieilles démarches qui ont d'autres champs en erreur.

J'en profite pour :

  • refactorer
  • rajouter les tests
  • passer le job sur sidekiq

@colinux colinux added the bug label Jan 29, 2024
@colinux colinux changed the title Tech: fix le job de vérification des liens des procédures lorsqu'un autre attribut est en erreur Tech: fix le job de vérification des liens externes des procédures lorsqu'un autre attribut est en erreur Jan 29, 2024
Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Improved Error Checking in Procedure Object
    • The update improves upon the existing logic for detecting and handling errors when working with our workflow 'procedure' object, making it more efficient and reliable.
  • Consolidation of Update Operations
    • Rather than updating attributes individually, they're now being assigned in a more streamlined and direct way, reducing code complexity.
  • New Error Checking Method
    • A new private method (check_for_error) has been added to handle error verification and provide clearer error messages.
  • Adoption of Sidekiq for Job Queueing
    • A brand new class (ProcedureExternalURLCheckJob) was created which uses 'Sidekiq' - a more modern, efficient tool for managing background jobs.
  • Introduction of Comprehensive Testing
    • A separate file with tests for the newly created class has been added. It comprehensively checks various scenarios for valid and invalid links in the 'Procedure' object, ensuring the new updates work as expected.

@colinux colinux added this pull request to the merge queue Jan 29, 2024
Merged via the queue into demarches-simplifiees:main with commit df1dd19 Jan 29, 2024
15 checks passed
@colinux colinux deleted the fix-procedure-external-url branch January 29, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants