Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin je peux faire un routage simple à partir d'un type de champ communes ou epci #9955

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

E-L-T
Copy link
Contributor

@E-L-T E-L-T commented Jan 31, 2024

La fonctionnalité n'était qu'à moitié codée. Maintenant en faisant un routage simple à partir d'un champ communes ou epci, on crée un groupe par département avec une règle de routage du type "Ma commune est dans le département..."

Copy link

what-the-diff bot commented Jan 31, 2024

PR Summary

  • Enhancements to the Group Formation Method
    Changes have been done to the method responsible for creating groups. It now recognizes two new types - communes and epci, allowing for a more customizable formation based on different TypeDeChamp. This adjustment should bring more flexibility in the way the groups are formed.

  • Improved User Guidance for CSV Import
    Improvements were made to guide users better when importing a CSV file. The system will now render helpful messages, advising about the correct file type needed based on the routing status, helping to avoid errors during the process.

  • Expanded Testing for Group Creation
    More tests have been added to better validate the group creation functionality, specifically for communes and epci types. These additional checks should ensure that the system is correctly setting up groups and routing rules, and supporting a smoother and error-free group formation process.

@E-L-T E-L-T force-pushed the fix-simple-routing branch from 60fead1 to b04f152 Compare January 31, 2024 14:28
@E-L-T E-L-T marked this pull request as ready for review January 31, 2024 14:46
@E-L-T E-L-T changed the title ETQ admin je peux utiliser l'assistant du routage simple avec les types de champ communes et epci ETQ admin je peux faire un routage simple à partir d'un type de champ communes ou epci Jan 31, 2024
@E-L-T E-L-T added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 7b539c7 Feb 13, 2024
15 checks passed
@E-L-T E-L-T deleted the fix-simple-routing branch February 13, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants