Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech(perf.rebase): améliore la performance pour réconcilier les dossiers d'une procédure lorsqu'un administrateur change le formulaire (donc nouveau milésime 🍷) #9956

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Jan 31, 2024

on avait 3 n+1 qui trainaient dans le coin. 30s en moyenne pour un rebase me semble BCP trop, donc en en resumé et hotfix, si on compare cette branch sur cette branche a main :

cette branch

➜  demarches-simplifiees.fr git:(US/amelioration-rebase) ✗ cat log/development.log | grep "11d7f37f-b6fb-48af-9763-200a0c68a6ad" > log.rebase.job 
➜  demarches-simplifiees.fr git:(US/amelioration-rebase) ✗ wc -l log.rebase.job 
     259 log.rebase.job

en comparaisant avec main: (un dossier de la mm demarche).

➜  demarches-simplifiees.fr git:(US/amelioration-rebase) ✗ cat log/development.log | grep "a420d5f0-f125-4ae8-a7a4-3d92c7b27168" > log.main.rebase.job
➜  demarches-simplifiees.fr git:(main) ✗ wc -l log.main.rebase.job
     605 log.main.rebase.job

@mfo mfo enabled auto-merge January 31, 2024 15:52
@mfo mfo force-pushed the US/amelioration-rebase branch from e08b6b0 to 437b3d2 Compare January 31, 2024 16:06
@mfo mfo changed the title perf(rebase): includes champs.types de champs instead of n+1 on this one tech(perf.rebase): améliore la performance pour réconcilier les dossiers d'une procédure lorsqu'un administrateur change le formulaire (donc nouveau milésime) Jan 31, 2024
@mfo mfo changed the title tech(perf.rebase): améliore la performance pour réconcilier les dossiers d'une procédure lorsqu'un administrateur change le formulaire (donc nouveau milésime) tech(perf.rebase): améliore la performance pour réconcilier les dossiers d'une procédure lorsqu'un administrateur change le formulaire (donc nouveau milésime 🍷) Jan 31, 2024
@mfo mfo added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@mfo mfo added this pull request to the merge queue Jan 31, 2024
Merged via the queue into demarches-simplifiees:main with commit 86fb28b Jan 31, 2024
15 checks passed
@mfo mfo deleted the US/amelioration-rebase branch January 31, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants