feat(email): stricter validation #9978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchak
reviewed
Feb 9, 2024
mfo
force-pushed
the
US/enforce-real-email-validation
branch
3 times, most recently
from
0bf1039 to
6571621
Compare
mfo
changed the title
mfo
force-pushed
the
US/enforce-real-email-validation
branch
9 times, most recently
from
13b698e to
fb39bf4
Compare
colinux
reviewed
Feb 14, 2024
mfo
force-pushed
the
US/enforce-real-email-validation
branch
4 times, most recently
from
446d82d to
ee97c78
Compare
colinux
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…mps::EmailChamp.value only on validation context Co-authored-by: Paul Chavard <github@paul.chavard.net>
…mation, Invite, DossierTransfert
…Champ.value, simplier default strict validation activation Co-authored-by: Colin Darie <colin@darie.eu>
mfo
force-pushed
the
US/enforce-real-email-validation
branch
from
ee97c78 to
8488e74
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
feat(email): stricter validation
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
demarches-simplifiees:main
with commit Feb 16, 2024
cc53946
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hs: https://secure.helpscout.net/conversation/2465440187/2050709/
verifier les autres parties du code qui utilisent Devise.email_regexp et utiliser la nouvelle constante
TODO: add env var
ENV['STRICT_EMAIL_VALIDATION_STARTS_ON'] = Time.now+1.dayafter deploy (env var must be set after deploy, otherwise their is a risk having instances validated with this method but not compliant with the validtion rule, can stuck your system). then stricter validation will start kicking of