-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch file #1704
Fetch file #1704
Conversation
What is the feature?Does it have an issue?No. Looks like its a bullet point of #1691 What is it doing?ExplanationImplements fetch file presumably for the frontend since Questions
Answers?What is the File protocol?
ConsiderationsSecurity restrictionsAccording to Gemini "Most browsers and environments restrict file protocol Edge CasesNon-existent FilesWe might have to handle non-existent files gracefully if we can't just use the PermissionsWe might have to worry about permissions if we can't just use the default In short I hope we can just use the default fetch. ExpectationsTestsI guess I would expect a front end that is able to get a local file and... do CodeHopefully just hand off to the default implementation of fetch. Footnotes
|
Okay this is definitely a canister side fetch, that's a horse of a different color. Let's start over |
Should this be implemented?I've started reading some stuff about how node fetch doesn't actually implement the file protocol, so we might not should do it either. I'll do some more research including working more with tensor flow to see what exactly it needs the file protocol for and make sure we are understanding its needs correctly. |
This PR implements
file://
for fetch from a canister, not from the frontend. It also has example code and tests. This is a very simple version of file://