Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full stdlib #382

Closed
wants to merge 86 commits into from
Closed

Full stdlib #382

wants to merge 86 commits into from

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented May 12, 2023 •
edited
Loading

Closes: #361
Closes: #12

lastmjs added 24 commits June 1, 2023 15:58
@lastmjs
only compile the stdlib one time, python source code compiled with th…
b0627d1 
…e app binary now
@lastmjs
we only compile the python stdlib lib once per version of kybra, we o…
88edc82 
…nly upload it once on init
@lastmjs
full flow seems to be working
272375b
@lastmjs
clean up verbose and error handling in kybra_modules_init
04f3c38
@lastmjs
general cleanup, use notify instead of regular call to install code
7fbbe8d
@lastmjs
remove comments, clean up
ae0e518
@lastmjs
clean up the deployer, make init and post_upgrade robust
d8b5428
@lastmjs
add authorization to the deployer
f9001db
@lastmjs
getting rid of the init method for now
0e0905c
@lastmjs
add in the network option for the kybra modules init
4970136
@lastmjs
get the init and post_upgrade params to work from the deployer
908f9d2
@lastmjs
Merge branch 'main' into full_stdlib
656e944
@lastmjs
fixes after merge
a2c80e8
@lastmjs
change all memory ids
95b32d5
@lastmjs
add in delays
0d46d48
@lastmjs
fix post_upgrade args
eb91d5b
@lastmjs
attemp to fix a few of the remaining tests
b4a864c
@lastmjs
fix whoami tests
975ec40
@lastmjs
fix stable structures example
33d5323
@lastmjs
fixed random seed issues
ae47207
@lastmjs
fix stable memory tests
4d6a12a
@lastmjs
add KYBRA_REBUILD=true to all tests
d29050b
@lastmjs
add dfx cache
dc2805f
@lastmjs
remove --verbose
d18ddd2
lastmjs
lastmjs commented Jun 26, 2023
View reviewed changes
kybra/__main__.py Outdated Show resolved Hide resolved
kybra/__main__.py Outdated Show resolved Hide resolved
kybra/compiler/kybra_deployer/src/lib.rs Show resolved Hide resolved
kybra/compiler/kybra_generate/src/canister_method/post_upgrade_method/build.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_generate/src/canister_method/post_upgrade_method/rust.rs Show resolved Hide resolved
kybra/compiler/kybra_generate/src/header/ref_cells.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_post_install/build.rs Show resolved Hide resolved
kybra/compiler/kybra_post_install/src/main.rs Show resolved Hide resolved
dansteren
dansteren suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@dansteren dansteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can review together but these are my general thoughts. Some might make sense, some not. Just follow your gut and ignore things you think are irrelevant.

kybra/compiler/kybra_deployer/src/lib.rs Show resolved Hide resolved
kybra/compiler/kybra_generate/src/canister_method/post_upgrade_method/build.rs Show resolved Hide resolved
kybra/compiler/kybra_generate/src/canister_method/post_upgrade_method/build.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_generate/src/canister_method/post_upgrade_method/build.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_generate/src/canister_method/post_upgrade_method/build.rs Show resolved Hide resolved
kybra/compiler/kybra_post_install/src/main.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_post_install/src/main.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_post_install/src/main.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_post_install/src/main.rs Outdated Show resolved Hide resolved
kybra/compiler/kybra_post_install/src/main.rs Outdated Show resolved Hide resolved
@lastmjs lastmjs closed this Jun 29, 2023
@lastmjs lastmjs deleted the full_stdlib branch July 14, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann requested changes

@dansteren dansteren dansteren requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kybra Modules Init and Stdlib stdlib
3 participants
@lastmjs @dansteren @bdemann