Fix more tests.

demiankatz · Dec 17, 2024 · 62bc876 · 62bc876
1 parent bdb8bfe
commit 62bc876
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/module/VuFind/src/VuFindTest/Feature/TranslatorTrait.php b/module/VuFind/src/VuFindTest/Feature/TranslatorTrait.php
@@ -56,7 +56,11 @@ protected function getMockTranslator(array $translations, string $locale = 'en')
         $callback = function ($str, $domain) use ($translations) {
             return $translations[$domain][$str] ?? $str;
         };
-        $translator = $this->createMock(Translator::class);
+        $translator = $this->getMockBuilder(Translator::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['translate'])
+            ->addMethods(['getLocale'])
+            ->getMock();
         $translator->expects($this->any())->method('translate')->willReturnCallback($callback);
         $translator->expects($this->any())->method('getLocale')->willReturn($locale);
         return $translator;

diff --git a/module/VuFind/tests/unit-tests/src/VuFindTest/View/Helper/Root/TranslateTest.php b/module/VuFind/tests/unit-tests/src/VuFindTest/View/Helper/Root/TranslateTest.php
@@ -457,10 +457,7 @@ public function testLocaleWithoutTranslator(): void
     public function testLocaleWithTranslator(): void
     {
         $translate = new Translate();
-        $translator = $this->createMock(\Laminas\Mvc\I18n\Translator::class);
-        $translator->expects($this->once())->method('getLocale')
-            ->will($this->returnValue('foo'));
-        $translate->setTranslator($translator);
+        $translate->setTranslator($this->getMockTranslator([], 'foo'));
         $this->assertEquals('foo', $translate->getTranslatorLocale());
     }