Fix sidebar margins and padding on narrow screens (vufind-org#4130)

Fixes margin between search tools and sidebar and the bottom padding of sidebar in sandal and sandal5.
demiankatz · Dec 3, 2024 · 7da2951 · 7da2951
1 parent 58fa0c6
commit 7da2951
Show file tree

Hide file tree

Showing 15 changed files with 30 additions and 24 deletions.
diff --git a/themes/bootprint3/css/compiled.css b/themes/bootprint3/css/compiled.css
diff --git a/themes/bootstrap3/css/compiled.css b/themes/bootstrap3/css/compiled.css
diff --git a/themes/bootstrap3/less/components/search.less b/themes/bootstrap3/less/components/search.less
@@ -434,6 +434,8 @@ body.rtl {
 }
 
 .searchtools {
+  margin-bottom: 0.5rem;
+
   h2 {
     display: inline-block;
     margin: 0;

diff --git a/themes/bootstrap3/less/components/sidebar.less b/themes/bootstrap3/less/components/sidebar.less
@@ -1,8 +1,11 @@
 .facet-group {
   display: block;
-  margin-bottom: 1rem;
   padding-left: 0;
 
+  &:not(:last-child) {
+    margin-bottom: 1rem;
+  }
+
   [data-toggle="collapse"] {
     cursor: pointer;
   }

diff --git a/themes/bootstrap3/scss/components/search.scss b/themes/bootstrap3/scss/components/search.scss
@@ -434,6 +434,8 @@ body.rtl {
 }
 
 .searchtools {
+  margin-bottom: 0.5rem;
+
   h2 {
     display: inline-block;
     margin: 0;

diff --git a/themes/bootstrap3/scss/components/sidebar.scss b/themes/bootstrap3/scss/components/sidebar.scss
@@ -1,8 +1,11 @@
 .facet-group {
   display: block;
-  margin-bottom: 1rem;
   padding-left: 0;
 
+  &:not(:last-child) {
+    margin-bottom: 1rem;
+  }
+
   [data-toggle="collapse"] {
     cursor: pointer;
   }

diff --git a/themes/bootstrap5/css/compiled.css b/themes/bootstrap5/css/compiled.css
diff --git a/themes/bootstrap5/scss/components/search.scss b/themes/bootstrap5/scss/components/search.scss
@@ -434,6 +434,8 @@ body.rtl {
 }
 
 .searchtools {
+  margin-bottom: 0.5rem;
+
   h2 {
     display: inline-block;
     margin: 0;

diff --git a/themes/bootstrap5/scss/components/sidebar.scss b/themes/bootstrap5/scss/components/sidebar.scss
@@ -1,8 +1,11 @@
 .facet-group {
   display: block;
-  margin-bottom: 1rem;
   padding-left: 0;
 
+  &:not(:last-child) {
+    margin-bottom: 1rem;
+  }
+
   [data-toggle="collapse"] {
     cursor: pointer;
   }

diff --git a/themes/local_theme_example/css/compiled.css b/themes/local_theme_example/css/compiled.css
diff --git a/themes/sandal/css/compiled.css b/themes/sandal/css/compiled.css
diff --git a/themes/sandal/less/sandal.less b/themes/sandal/less/sandal.less
@@ -197,9 +197,7 @@ a:hover .login-dropdown-caret {
 
 /* --- Sidebar --- */
 .sidebar {
-  padding-top: 1rem;
-  padding-left: 1rem;
-  padding-right: 1rem;
+  padding: 1rem;
   font-size: @reduced-font-size;
   background-color: @light-gray;
 
@@ -270,7 +268,6 @@ a:hover .login-dropdown-caret {
 
 @media (max-width: 1399px) {
   .sidebar {
-    padding-left: 0.5rem;
-    padding-right: 0.5rem;
+    padding: 1rem 0.5rem 0.5rem 0.5rem;
   }
 }
diff --git a/themes/sandal/scss/sandal.scss b/themes/sandal/scss/sandal.scss
@@ -197,9 +197,7 @@ a:hover .login-dropdown-caret {
 
 /* --- Sidebar --- */
 .sidebar {
-  padding-top: 1rem;
-  padding-left: 1rem;
-  padding-right: 1rem;
+  padding: 1rem;
   font-size: $reduced-font-size;
   background-color: $light-gray;
 
@@ -270,7 +268,6 @@ a:hover .login-dropdown-caret {
 
 @media (max-width: 1399px) {
   .sidebar {
-    padding-left: 0.5rem;
-    padding-right: 0.5rem;
+    padding: 1rem 0.5rem 0.5rem 0.5rem;
   }
 }
diff --git a/themes/sandal5/css/compiled.css b/themes/sandal5/css/compiled.css
diff --git a/themes/sandal5/scss/sandal.scss b/themes/sandal5/scss/sandal.scss
@@ -196,9 +196,7 @@ a:hover .login-dropdown-caret {
 
 /* --- Sidebar --- */
 .sidebar {
-  padding-top: 1rem;
-  padding-left: 1rem;
-  padding-right: 1rem;
+  padding: 1rem;
   font-size: $reduced-font-size;
   background-color: $light-gray;
 
@@ -269,7 +267,6 @@ a:hover .login-dropdown-caret {
 
 @media (max-width: 1399px) {
   .sidebar {
-    padding-left: 0.5rem;
-    padding-right: 0.5rem;
+    padding: 1rem 0.5rem 0.5rem 0.5rem;
   }
 }