Switch from GET to POST.

demiankatz · Dec 16, 2024 · 83463bd · 83463bd
1 parent 7d78911
commit 83463bd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/module/VuFind/src/VuFind/AjaxHandler/DoiLookup.php b/module/VuFind/src/VuFind/AjaxHandler/DoiLookup.php
@@ -124,8 +124,7 @@ public function __construct(
     public function handleRequest(Params $params)
     {
         $response = [];
-        $rawIds = (array)$params->fromQuery('id', []);
-        $ids = array_map(fn ($id) => json_decode($id, true), $rawIds);
+        $ids = json_decode($params->getController()->getRequest()->getContent(), true);
         foreach ($this->resolvers as $resolver) {
             if ($this->pluginManager->has($resolver)) {
                 $next = $this->pluginManager->get($resolver)->getLinks($ids);

diff --git a/themes/bootstrap3/js/doi.js b/themes/bootstrap3/js/doi.js
@@ -3,26 +3,27 @@ VuFind.register('doi', function Doi() {
   function embedDoiLinks(el) {
     var queryParams = new URLSearchParams();
     var elements = el.classList.contains('doiLink') ? [el] : el.querySelectorAll('.doiLink');
+    var postBody = {};
     elements.forEach(function extractIdentifierData(doiLinkEl) {
       var currentInstance = doiLinkEl.dataset.instance;
-      if (!queryParams.has(`id[${currentInstance}]`)) {
+      if (typeof postBody[currentInstance] === "undefined") {
         let currentIdentifiers = {};
         ["doi", "issn", "isbn"].forEach(identifier => {
           if (typeof doiLinkEl.dataset[identifier] !== "undefined") {
             currentIdentifiers[identifier] = doiLinkEl.dataset[identifier];
           }
         });
         if (Object.keys(currentIdentifiers).length > 0) {
-          queryParams.set(`id[${currentInstance}]`, JSON.stringify(currentIdentifiers));
+          postBody[currentInstance] = currentIdentifiers;
         }
       }
     });
-    if (queryParams.toString().length === 0) {
+    if (Object.keys(postBody).length === 0) {
       return;
     }
     queryParams.set("method", "doiLookup");
     var url = VuFind.path + '/AJAX/JSON?' + queryParams.toString();
-    fetch(url, { method: "GET" })
+    fetch(url, { method: "POST", body: JSON.stringify(postBody) })
       .then(function embedDoiLinksDone(rawResponse) {
         elements.forEach(function populateDoiLinks(doiEl) {
           var currentInstance = doiEl.dataset.instance;

diff --git a/themes/bootstrap5/js/doi.js b/themes/bootstrap5/js/doi.js
@@ -3,26 +3,27 @@ VuFind.register('doi', function Doi() {
   function embedDoiLinks(el) {
     var queryParams = new URLSearchParams();
     var elements = el.classList.contains('doiLink') ? [el] : el.querySelectorAll('.doiLink');
+    var postBody = {};
     elements.forEach(function extractIdentifierData(doiLinkEl) {
       var currentInstance = doiLinkEl.dataset.instance;
-      if (!queryParams.has(`id[${currentInstance}]`)) {
+      if (typeof postBody[currentInstance] === "undefined") {
         let currentIdentifiers = {};
         ["doi", "issn", "isbn"].forEach(identifier => {
           if (typeof doiLinkEl.dataset[identifier] !== "undefined") {
             currentIdentifiers[identifier] = doiLinkEl.dataset[identifier];
           }
         });
         if (Object.keys(currentIdentifiers).length > 0) {
-          queryParams.set(`id[${currentInstance}]`, JSON.stringify(currentIdentifiers));
+          postBody[currentInstance] = currentIdentifiers;
         }
       }
     });
-    if (queryParams.toString().length === 0) {
+    if (Object.keys(postBody).length === 0) {
       return;
     }
     queryParams.set("method", "doiLookup");
     var url = VuFind.path + '/AJAX/JSON?' + queryParams.toString();
-    fetch(url, { method: "GET" })
+    fetch(url, { method: "POST", body: JSON.stringify(postBody) })
       .then(function embedDoiLinksDone(rawResponse) {
         elements.forEach(function populateDoiLinks(doiEl) {
           var currentInstance = doiEl.dataset.instance;