source_group() settings are wrong for non-IDE builds #27
Comments
demianmnave
added a commit
that referenced
this issue
May 14, 2021
demianmnave
added a commit
that referenced
this issue
May 14, 2021
* Tidy up the CMake build, add an installation option, tidy up AppVeyor using the Ninja CMake generator, and fix _source_group(...)_ usage Closes #27, #29, #30, #31 * Restore Visual Studio build functionality, and add GCC and Clang entries for testing * Use pwsh for the test_script, fix the Visual Studio generator specifications, and set the CMAKE_BUILD_TYPE for the Ubuntu bulds * Remove spaces from the CMake arch and toolset, as this seems to confuse CMake when called from pwsh * Move CMAKE_BUILD_TYPE back under the Ubuntu builds, specify Clang and GCC command versions explicitly, and explicitly set the path before running ctest * Enable concurrent builds for the Visual Studio generators, and only change to the "build" directory if not already there
demianmnave
added a commit
that referenced
this issue
May 15, 2021
* Made the CML target into a real interface library, added a convenience custom_target to see headers in an IDE, and changed to use CMake C++ feature tests * Updated to Catch2 * Updates to account for CMake C++ feature tests and dropping support for older compilers * Downgrade CMake requirement to 3.12.4. * Add .gitignore * Update to Catch2 2.13.4 * Remove older XCode builds, specify C++ standard * Add C++ standard, clean up CMake command line * Minor fixes to TravisCI and AppVeyor yml * More AppVeyor yml fixes * Fix AppVeyor yaml syntax error * Attempting AppVeyor fix again * AppVeyor fix attempt, again * Enable RDP to debug CMake * Remove extra builds temporarily * Testing vcvars call * Fix VCPATH * Fix VCPATH usage * Remove AppVeyor clang-cl build for now * Tidy up CMakeLists.txt and AppVeyor (#32) * Tidy up the CMake build, add an installation option, tidy up AppVeyor using the Ninja CMake generator, and fix _source_group(...)_ usage Closes #27, #29, #30, #31 * Restore Visual Studio build functionality, and add GCC and Clang entries for testing * Use pwsh for the test_script, fix the Visual Studio generator specifications, and set the CMAKE_BUILD_TYPE for the Ubuntu bulds * Remove spaces from the CMake arch and toolset, as this seems to confuse CMake when called from pwsh * Move CMAKE_BUILD_TYPE back under the Ubuntu builds, specify Clang and GCC command versions explicitly, and explicitly set the path before running ctest * Enable concurrent builds for the Visual Studio generators, and only change to the "build" directory if not already there * Bump version to 2.2.0 * Fix TravisCI build (remove Ubuntu), and enable AppVeyor and TravisCI on master Co-authored-by: Demian M. Nave <dnave@propulsor.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In CML.cmake,
_header_groupis empty for non-IDE builds, which makes no sense. CMake 3.12+ doesn't appear to complain, but it should be fixed.The text was updated successfully, but these errors were encountered: