Skip to content

Commit

Permalink
RedCanary: Fixed an issue where the same detection was fetched multip…
Browse files Browse the repository at this point in the history
…le times. (#27459)

* Fixed an issue where the same detection was fetched multiple times.

* update Docker image
  • Loading branch information
moishce authored and TalNos committed Jun 16, 2023
1 parent 1f266b2 commit 6db9946
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
8 changes: 4 additions & 4 deletions Packs/RedCanary/Integrations/RedCanary/RedCanary.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,14 @@ def process_timeline(detection_id):
'attributes', {}).get('command_line'),
}
files.append({
'Name': os.path.basename(image.get('path')),
'Name': os.path.basename(image.get('path', '')),
'MD5': image.get('md5'),
'SHA256': image.get('sha256'),
'Path': image.get('path'),
'Extension': os.path.splitext(image['path'])[-1],
'Extension': os.path.splitext(image.get('path', ''))[-1],
})
processes.append({
'Name': os.path.basename(image.get('path')),
'Name': os.path.basename(image.get('path', '')),
'Path': image.get('path'),
'MD5': image.get('md5'),
'SHA256': image.get('sha256'),
Expand Down Expand Up @@ -571,7 +571,7 @@ def fetch_incidents(last_run):
if incident_id not in last_incidents_ids:
# makes sure that the incident wasn't fetched before
incidents.append(incident)
new_incidents_ids.append(incident_id)
new_incidents_ids.append(incident_id)

if incidents:
last_fetch = max([get_time_obj(incident['occurred']) for incident in incidents]) # noqa:F812
Expand Down
2 changes: 1 addition & 1 deletion Packs/RedCanary/Integrations/RedCanary/RedCanary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ script:
script: ''
type: python
subtype: python3
dockerimage: demisto/python3:3.10.11.61265
dockerimage: demisto/python3:3.10.12.62631
commands:
- name: redcanary-acknowledge-detection
arguments:
Expand Down
6 changes: 6 additions & 0 deletions Packs/RedCanary/ReleaseNotes/1_1_14.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Red Canary
- Fixed an issue where the same detection was fetched multiple times.
- Updated the Docker image to: *demisto/python3:3.10.12.62631*.
2 changes: 1 addition & 1 deletion Packs/RedCanary/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Red Canary",
"description": "Red Canary collects endpoint data using Carbon Black Response and CrowdStrike Falcon. The collected data is standardized into a common schema which allows teams to detect, analyze and respond to security incidents.",
"support": "xsoar",
"currentVersion": "1.1.13",
"currentVersion": "1.1.14",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down

0 comments on commit 6db9946

Please sign in to comment.