CreateEmailHtmlBody fix false values (#32712)

* CreateEmailHtmlBody fix false values * RN
demisto · Feb 5, 2024 · e29c886 · e29c886
1 parent 55ab6e7
commit e29c886
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/Packs/CommonScripts/ReleaseNotes/1_13_34.md b/Packs/CommonScripts/ReleaseNotes/1_13_34.md
@@ -0,0 +1,6 @@
+
+#### Scripts
+
+##### CreateEmailHtmlBody
+
+- Fixed an issue where fields with false values was not being copied correctly.
diff --git a/Packs/CommonScripts/Scripts/CreateEmailHtmlBody/CreateEmailHtmlBody.js b/Packs/CommonScripts/Scripts/CreateEmailHtmlBody/CreateEmailHtmlBody.js
@@ -29,26 +29,33 @@ while (found = reg.exec(html)) {
     var path = found[1];
 
     if (path.indexOf('incident.labels.') === 0) {
+        logDebug("Field " + path + " is handled as label.")
         map[path] = getLabel(incidents[0], path);
+
     } else if (path.indexOf('incident.') === 0) {
         map[path] = dq({'incident': incidents[0]}, path);
-        // check if this path is actually in custom fields
-        if (!map[path]) {
+        // check if this path is actually in custom fields (not found directly under incident)
+        if (map[path] === null) {
+            logDebug("Field " + path + " is either custom or null. Handling as custom.")
             var customFieldPath = path.replace('incident.', 'incident.CustomFields.');
             map[path] = dq({'incident': incidents[0]}, customFieldPath);
         }
     } else if (path.indexOf('object.') === 0) {
+        logDebug("Field " + path + " is part of object.")
+
         var obj = (typeof args.object === 'string') ? JSON.parse(args.object) : args.object;
         map[path] = dq({'object': obj}, path);
     } else {
         map[path] = dq(invContext, path);
     }
 }
+logDebug("Field value fetched: " + map[path])
 
 // replacing all placeholders with values
 for (var path in map) {
-    // if value found replace. Otherwise will leave placeholder
-    if (map[path]) {
+    // if value is found - replace. Otherwise will leave placeholder.
+    if (map[path] !== null) {
+        logDebug("Replacing value in " + path + " to " + map[path])
         html = html.replaceAll('${' + path + '}', map[path]);
     } else if (args.removeNotFound === 'yes') {
         html = html.replaceAll('${' + path + '}', '');

diff --git a/Packs/CommonScripts/pack_metadata.json b/Packs/CommonScripts/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "Common Scripts",
     "description": "Frequently used scripts pack.",
     "support": "xsoar",
-    "currentVersion": "1.13.33",
+    "currentVersion": "1.13.34",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",