Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiscoASA argument fix #10676

Merged
merged 4 commits into from
Dec 30, 2020
Merged

CiscoASA argument fix #10676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bec1b9d
fixed argument
moishce Dec 30, 2020
5fc1215
added release notes
moishce Dec 30, 2020
e444d88
Update 1_0_3.md
roysagi Dec 30, 2020
532ddc9
Merge branches 'CiscoASA_fix' and 'master' of github.com:demisto/cont…
moishce Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Packs/CiscoASA/Integrations/CiscoASA/CiscoASA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ def create_rule_command(client: Client, args):

remarks = argToList(args.get('remarks'), ',')
position = args.get('position')
log_level = args.get('logging_level')
log_level = args.get('log_level')
active = args.get('active', 'True')

rule_body = {} # type: dict
Expand Down Expand Up @@ -440,7 +440,7 @@ def edit_rule_command(client: Client, args):

remarks = argToList(args.get('remarks'), ',')
position = args.get('position')
log_level = args.get('logging_level')
log_level = args.get('log_level')
active = args.get('active', 'True')
source = args.get('source')
dest = args.get('destination')
Expand Down
2 changes: 1 addition & 1 deletion Packs/CiscoASA/Integrations/CiscoASA/CiscoASA.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ script:
- contextPath: CiscoASA.Interface.Type
description: The type of interface.
type: String
dockerimage: demisto/python3:3.8.3.9324
dockerimage: demisto/python3:3.8.6.14516
isfetch: false
runonce: false
script: '-'
Expand Down
5 changes: 5 additions & 0 deletions Packs/CiscoASA/ReleaseNotes/1_0_3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

#### Integrations
##### Cisco ASA
- Fixed an issue where the *log_level* argument in the **cisco-asa-create-rule** and the **cisco-asa-edit-rule** commands was not used correctly.
- Upgraded the Docker image to demisto/python3:3.8.6.14516.
4 changes: 2 additions & 2 deletions Packs/CiscoASA/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Cisco ASA",
"description": "Cisco Adaptive Security Appliance Software is the core operating system for the Cisco ASA Family. It delivers enterprise-class firewall capabilities for ASA devices.",
"support": "xsoar",
"currentVersion": "1.0.2",
"currentVersion": "1.0.3",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand All @@ -13,4 +13,4 @@
"tags": [],
"useCases": [],
"keywords": []
}
}