Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudshare fixed #10682

Merged
merged 5 commits into from
Dec 31, 2020
Merged

Cloudshare fixed #10682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
549e395
fixed
moishce Dec 30, 2020
00b2423
added release notes
moishce Dec 30, 2020
5b76627
Merge branches 'cloudshare_fixed' and 'master' of github.com:demisto/…
moishce Dec 30, 2020
a7281b6
fixed release notes
moishce Dec 30, 2020
9954a39
rm URL from metadata
moishce Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Packs/CloudShare/Integrations/CloudShare/CloudShare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,7 @@ def main() -> None:
'cloudshare-get-class': get_class_command,
'cloudshare-delete-class': delete_class_command,
'cloudshare-delete-class-environemtns': delete_class_environments_command, # This is here for maintaining BC
'cloudshare-delete-class-environemnts': delete_class_environments_command,
'cloudshare-delete-class-environments': delete_class_environments_command,
'cloudshare-get-classes-countries': get_classes_countries_command,
'cloudshare-get-classes-customfields': get_classes_customfields_command,
'cloudshare-get-classes-detailed': get_classes_detailed_command,
Expand All @@ -1180,7 +1180,8 @@ def main() -> None:
'cloudshare-suspend-class-environments': suspend_class_environments_command,
'cloudshare-modify-class': modify_class_command,
'cloudshare-get-students': get_students_command,
'cloudshare-get-student': delete_student_command,
'cloudshare-get-student': get_student_command,
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir Dec 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'cloudshare-get-student': get_student_command,
'cloudshare-get-student': get_students_command, # This is here for maintaining BC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just for bc
"cloudshare-get-student" command exists in the yml and has a function in the code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so in the YML there is 2 command (students and student) and in the py file only one right? Let's change the comment to explain that # Both commands (get-student and get-students) use the same function
While you are at it please remove the paloaltonetworks URL from the metadata file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in the py file there is 2 functions (students and student)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sorry I missed it. So no need to comment. But change the metadata

'cloudshare-delete-student': delete_student_command,
'cloudshare-register-student': register_student_command,
'cloudshare-modify-student': modify_student_command,
'cloudshare-get-regions': get_regions_command,
Expand Down
2 changes: 1 addition & 1 deletion Packs/CloudShare/ReleaseNotes/1_0_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

#### Integrations
##### CloudShare (Beta)
- Fixed an issue where the **cloudshare-delete-class-environemnts** command was incorrectly handled in the code.
- Fixed an issue where the **cloudshare-delete-class-environments** command was incorrectly handled in the code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you can edit a pre-existing RN.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is true

4 changes: 4 additions & 0 deletions Packs/CloudShare/ReleaseNotes/1_0_2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

#### Integrations
##### CloudShare (Beta)
Fixed an issue where the ***cloudshare-delete-student*** and the ***cloudshare-get-student*** commands were incorrectly handled in the code.
4 changes: 2 additions & 2 deletions Packs/CloudShare/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"name": "CloudShare",
"description": "CloudShare integration",
"support": "community",
"currentVersion": "1.0.1",
"currentVersion": "1.0.2",
"author": "Adam Burt",
"url": "https://www.paloaltonetworks.com/cortex",
"url": "",
"email": "",
"created": "2020-10-27T10:35:00Z",
"categories": [
Expand Down