Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O365 - Security And Compliance - Validate sc-auth-start run before sc-auth-complete #10707

Merged
merged 36 commits into from
Jan 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
3573269
All commands implemented - Before review
Dec 6, 2020
95f8085
Merge branch 'master' of github.com:demisto/content into EwsExtension
Dec 6, 2020
d8ec0d8
Merge branch 'master' of github.com:demisto/content into EwsExtension
Dec 9, 2020
a77c71f
Add Base pack
Dec 9, 2020
bdb3df8
Add retry mech
Dec 9, 2020
8a00aa0
Merge branch 'master' of github.com:demisto/content into EwsExtension
Dec 9, 2020
ac84b5b
Updated
kirbles19 Dec 14, 2020
ecadbf5
Updated
kirbles19 Dec 14, 2020
725f326
Updated text and formatting
kirbles19 Dec 14, 2020
29476c2
Updated
kirbles19 Dec 16, 2020
1aa04f3
Updated
kirbles19 Dec 16, 2020
6e37a0b
Updated
kirbles19 Dec 16, 2020
048f79b
Merge remote-tracking branch 'origin/master' into EwsExtension
yaakovi Dec 24, 2020
e4a4f37
fixed few typos
yaakovi Dec 24, 2020
a53fd9a
fixed typo
yaakovi Dec 24, 2020
0d26e4f
fixed few typos
yaakovi Dec 24, 2020
4b353ba
Merge remote-tracking branch 'origin/master' into EwsExtension
yaakovi Dec 24, 2020
96d3bd8
Update Packs/EWS/Integrations/EwsExtension/EwsExtension_description.md
GalRabin Dec 29, 2020
527e7f2
Update EwsExtension.yml
GalRabin Dec 29, 2020
e9ee0db
Validate sc-auth-start run before sc-auth-complete
Jan 2, 2021
c3ea374
Merge branch 'master' of github.com:demisto/content into EwsExtension
Jan 3, 2021
ec2f6ef
Update Packs/EWS/pack_metadata.json
GalRabin Jan 3, 2021
20554ac
After review 001
Jan 3, 2021
5e718b4
Readme
Jan 3, 2021
0009091
Merge branch 'master' of github.com:demisto/content into EwsExtension
Jan 3, 2021
fb39ddd
Fix readme table
Jan 3, 2021
622461a
fix table in readme
Jan 3, 2021
6100882
fix table in readme
Jan 3, 2021
8ffaa88
release note
Jan 3, 2021
908014a
Update Packs/EWS/Integrations/EwsExtension/EwsExtension.yml
GalRabin Jan 5, 2021
161cc23
Merge branch 'master' of github.com:demisto/content into EwsExtension
Jan 5, 2021
c852d3d
Update Packs/EWS/ReleaseNotes/1_6_2.md
GalRabin Jan 5, 2021
fa0f0bb
Update Packs/EWS/ReleaseNotes/1_6_2.md
GalRabin Jan 5, 2021
38f74cd
Merge branch 'master' into SecurityAndComplianceHanldeLogIn
GalRabin Jan 5, 2021
6fdb15e
Merge branch 'SecurityAndComplianceHanldeLogIn' of github.com:demisto…
Jan 5, 2021
ef69bb0
Release note after review
Jan 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Packs/EWS/Integrations/SecurityAndCompliance/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,12 @@ To access the Security & Compliance Center, you need to be a global administrato
2. Open playground - War-room:

1. Run the ***!o365-sc-auth-start*** command and follow the instructions. Expected output is:


>## Security And Compliance - Authorize instructions

> ## Security And Compliance - Authorize instructions
>
>1. To sign in, use a web browser to open the page [https://microsoft.com/devicelogin](https://microsoft.com/devicelogin) and enter the code **XXXXXXX** to authenticate.
>2. Run the command ***!o365-sc-auth-complete*** command in the War Room.

> 1. To sign in, use a web browser to open the page [https://microsoft.com/devicelogin](https://microsoft.com/devicelogin) and enter the code **XXXXXXX** to authenticate.
> 2. Run the command ***!o365-sc-auth-complete*** command in the War Room.


2. Test - OAuth2.0 authorization, Run the ***!o365-sc-auth-test*** command.

2. Basic authentication (Not recommended):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1211,6 +1211,10 @@ function StartAuthCommand ([OAuth2DeviceCodeClient]$client) {
}

function CompleteAuthCommand ([OAuth2DeviceCodeClient]$client) {
# Verify that user run start before complete
if (!$client.device_code) {
throw "Please run !o365-sc-auth-start and follow the command instructions"
}
$raw_response = $client.AccessTokenRequest()
$human_readable = "Your account **successfully** authorized!"
$entry_context = @{}
Expand Down
4 changes: 4 additions & 0 deletions Packs/EWS/ReleaseNotes/1_7_1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

#### Integrations
##### O365 - Security And Compliance - Content Search (beta)
- Improved the integration setup error handling. Now validates that the user ran the ***o365-sc-auth-start*** command before running the ***o365-sc-auth-complete*** command.
4 changes: 2 additions & 2 deletions Packs/EWS/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "EWS",
"description": "Exchange Web Services and Office 365 (mail)",
"support": "xsoar",
"currentVersion": "1.7.0",
"currentVersion": "1.7.1",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand All @@ -13,4 +13,4 @@
"tags": [],
"useCases": [],
"keywords": []
}
}