Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSMalquery - unimplemented arguments fix #10726

Merged
merged 5 commits into from
Jan 5, 2021
Merged

CSMalquery - unimplemented arguments fix #10726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04819f7
fixed unimplemented arguments in the hunt and the exact-search commands.
Bargenish Jan 4, 2021
005b072
fixed typo
Bargenish Jan 4, 2021
a0d47ca
Update 1_0_2.md
Bargenish Jan 4, 2021
8064ffc
Update 1_0_2.md
roysagi Jan 5, 2021
bcd419c
Merge branch 'master' into CSMalquery-arg-fix
Bargenish Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Packs/CrowdStrikeMalquery/Integrations/CrowdStrikeMalquery/CrowdStrikeMalquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def exact_search_command(client: Client, args: dict) -> CommandResults:
# dates format: YYYY/MM/DD
query_filters = assign_params(limit=int(args.get('limit', '100')),
filter_meta=argToList(args.get('filter_meta')),
filter_filetypes=argToList(args.get('file_types')),
filter_filetypes=argToList(args.get('filter_filetypes')),
max_size=args.get('max_size'),
min_size=args.get('min_size'),
max_date=args.get('max_date'),
Expand Down Expand Up @@ -242,7 +242,7 @@ def hunt_command(client: Client, args: dict) -> CommandResults:
# dates format: YYYY/MM/DD
query_filters = assign_params(limit=int(args.get('limit', '100')),
filter_meta=argToList(args.get('filter_meta')),
filter_filetypes=argToList(args.get('file_types')),
filter_filetypes=argToList(args.get('filter_filetypes')),
max_size=args.get('max_size'),
min_size=args.get('min_size'),
max_date=args.get('max_date'),
Expand Down Expand Up @@ -304,7 +304,7 @@ def get_file_metadata_command(client: Client, args: dict):
integration_name=VENDOR_NAME,
score=DBOT_SCORE[file_label]
)
file_entry = Common.File(sha256=sha256, dbot_score=dbot_score)
file_entry = Common.File(sha256=sha256, md5=file.get('md5'), sha1=file.get('sha1'), dbot_score=dbot_score)
table_name = f'{VENDOR_NAME} File reputation for: {sha256}'
md = tableToMarkdown(table_name, file, removeNull=True)

Expand Down
14 changes: 13 additions & 1 deletion Packs/CrowdStrikeMalquery/Integrations/CrowdStrikeMalquery/CrowdStrikeMalquery.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,21 @@ script:
- contextPath: DBotScore.Indicator
description: The indicator that was tested.
type: String
- contextPath: DBotScore.Vendor
description: The vendor used to calculate the score.
type: String
- contextPath: File.Vendor
description: The vendor used to calculate the score.
type: String
- contextPath: File.MD5
description: The MD5 hash of the file.
type: String
- contextPath: File.SHA1
description: The SHA1 hash of the file.
type: String
- contextPath: File.SHA256
description: The SHA256 hash of the file.
type: String
- contextPath: Malquery.File.family
description: The malware family of the file. For example, StoneDrill.
type: String
Expand Down Expand Up @@ -351,7 +363,7 @@ script:
script: '-'
type: python
subtype: python3
dockerimage: demisto/python3:3.8.6.12176
dockerimage: demisto/python3:3.9.1.14969
fromversion: 5.0.0
tests:
- CrowdStrikeMalquery-Test
5 changes: 5 additions & 0 deletions Packs/CrowdStrikeMalquery/ReleaseNotes/1_0_2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

#### Integrations
##### CrowdStrike Malquery
- Fixed an issue where the *filter_filetypes* argument in the ***cs-malquery-hunt*** and the ***cs-malquery-exact-search*** commands was not used correctly.
- Updated Docker image to demisto/python3:3.9.1.14969.
2 changes: 1 addition & 1 deletion Packs/CrowdStrikeMalquery/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "CrowdStrike Malquery",
"description": "Use the MalQuery Pack to query the contents of over a half-billion binary files, both clean and malicious, that are part of Falcon MalQuery's corpus.",
"support": "xsoar",
"currentVersion": "1.0.1",
"currentVersion": "1.0.2",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down