Missing dependencies fix #19052
Merged
Missing dependencies fix #19052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 11, 2022 14:51
Noy-Maimon
requested review from
michalgold,
altmannyarden and
idovandijk
as code owners
Your contributed GoogleChronicleBackstory pack has been modified on files:Packs/GoogleChronicleBackstory/pack_metadata.json |
Your contributed CreatePlbkDoc pack has been modified on files:Packs/CreatePlbkDoc/pack_metadata.json |
idovandijk
reviewed
May 16, 2022
This has no effect on the 'demisto-sdk' upload command. |
Your contributed Wiz pack has been modified on files:Packs/Wiz/pack_metadata.json |
yaakovi
approved these changes
May 17, 2022
| Path(pack_with_dep_path).mkdir(parents=True, exist_ok=True) | ||
| if not (pack.zip_path and os.path.isfile(pack.zip_path)): | ||
| task_status = sign_and_zip_pack(pack, signature_key) | ||
| if pack.status not in [*SKIPPED_STATUS_CODES, PackStatus.SUCCESS.name]: |
israelpoli
pushed a commit
that referenced
this pull request
May 15, 2024
* ignore dependencies of packs from other MP * test pack * fix dependencies * fix random dependencies * debug logs * change * test change * remove failing pack * d * test change * remove testing * remove testing files * add removed pack * add removed pack * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: An issue where the upload flow was re-uploading packs that were not modified due to the 'missing dependencies' mechanism - these packs had misspelled dependencies, causing them to be marked as missing dependencies (and therefore re-uploaded).
Also: reduced 'upload packs with dependencies zip' to upload only modified packs or packs that their dependencies have been modified.