-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASM] - EXPANDR-2322 Dependencies #24443
[ASM] - EXPANDR-2322 Dependencies #24443
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilaner will know he can start review the proposed changes. |
@ilaner , please wait on merging this based on other dependencies found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we should alphabetical order on these, to increase readability and make it easier to catch duplicates.
"AccessInvestigation", | ||
"Asset", | ||
"Identity", | ||
"GoogleKeyManagementService", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate (refer to line 18).
"GoogleKeyManagementService", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the duplicate
"Asset", | ||
"Identity", | ||
"GoogleKeyManagementService", | ||
"AWS-Route53", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate (refer to line 12).
"AWS-Route53", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the duplicate
"Azure-Enrichment-Remediation", | ||
"MicrosoftGraphUser", | ||
"AzureCompute", | ||
"SplunkPy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnnywilkes we should include the dependencies that Azure-Enrichment-Remediation
needs even if they are optional if this is for auto-download.
"SplunkPy" | |
"SplunkPy", | |
"AzureNetworkSecurityGroups", | |
"MicrosoftGraphIdentityandAccess" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me. I'll let @capanw make the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @BigEasyJ @johnnywilkes. Made the suggested changes.
@ShahafBenYakir , just wanted to mention that we want to wait on this to be merged. Dependency is #24490 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@capanw , I approve this change!
"Nmap" | ||
"ServiceNow", | ||
"SplunkPy", | ||
"Tenable_io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ending comma as well.
Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://jira-hq.paloaltonetworks.local/browse/EXPANDR-2322
Description
Update Pre-install list with current dependencies
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have