Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - EXPANDR-2322 Dependencies #24443

Merged
merged 10 commits into from
Feb 15, 2023

Conversation

capanw
Copy link
Contributor

@capanw capanw commented Feb 7, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-2322

Description

Update Pre-install list with current dependencies

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! labels Feb 7, 2023
@content-bot content-bot changed the base branch from master to contrib/capanw_dependencies-01 February 7, 2023 21:15
@content-bot content-bot requested a review from ilaner February 7, 2023 21:16
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilaner will know he can start review the proposed changes.

@johnnywilkes
Copy link
Contributor

@ilaner , please wait on merging this based on other dependencies found

Copy link
Contributor

@BigEasyJ BigEasyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should alphabetical order on these, to increase readability and make it easier to catch duplicates.

"AccessInvestigation",
"Asset",
"Identity",
"GoogleKeyManagementService",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate (refer to line 18).

Suggested change
"GoogleKeyManagementService",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the duplicate

"Asset",
"Identity",
"GoogleKeyManagementService",
"AWS-Route53",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate (refer to line 12).

Suggested change
"AWS-Route53",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the duplicate

"Azure-Enrichment-Remediation",
"MicrosoftGraphUser",
"AzureCompute",
"SplunkPy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnnywilkes we should include the dependencies that Azure-Enrichment-Remediation needs even if they are optional if this is for auto-download.

Suggested change
"SplunkPy"
"SplunkPy",
"AzureNetworkSecurityGroups",
"MicrosoftGraphIdentityandAccess"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me. I'll let @capanw make the change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BigEasyJ @johnnywilkes. Made the suggested changes.

@johnnywilkes
Copy link
Contributor

@ShahafBenYakir , just wanted to mention that we want to wait on this to be merged. Dependency is #24490

Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , I approve this change!

"Nmap"
"ServiceNow",
"SplunkPy",
"Tenable_io",
Copy link
Contributor

@BigEasyJ BigEasyJ Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ending comma as well.

@ilaner ilaner merged commit 1c88932 into demisto:contrib/capanw_dependencies-01 Feb 15, 2023
ilaner pushed a commit that referenced this pull request Feb 16, 2023
Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
ayman-m pushed a commit to my-soar/content that referenced this pull request Feb 24, 2023
Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants