Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS GuardDuty - default mapper and classifier do not exist - fix #24685

Merged
merged 6 commits into from
Feb 20, 2023
Merged

AWS GuardDuty - default mapper and classifier do not exist - fix #24685

merged 6 commits into from
Feb 20, 2023

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Feb 16, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Breaking changes: Changed the default classifier name to AWSGuardDuty - Classifier and the default mapper name to AWSGuardDuty - Incoming Mapper.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@michal-dagan michal-dagan changed the title pr dummy AWS GuardDuty - default mapper and classifier do not exist - fix Feb 19, 2023
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/8ae23006-bfd2-4147-aea1-61aafda83e49/artifacts/0/artifacts/coverage_report/html/index.html

@michal-dagan michal-dagan marked this pull request as ready for review February 19, 2023 10:53
@michal-dagan michal-dagan requested a review from bziser February 19, 2023 10:55
bziser
bziser approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@michal-dagan michal-dagan merged commit ea1217e into master Feb 20, 2023
@michal-dagan michal-dagan deleted the aws_fix_mapper branch February 20, 2023 09:01
ayman-m pushed a commit to my-soar/content that referenced this pull request Feb 24, 2023
@michal-dagan @ayman-m
AWS GuardDuty - default mapper and classifier do not exist - fix (dem…
134b757 
…isto#24685)

* renamed mapper and classifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziser bziser bziser approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michal-dagan @xsoar-bot @bziser