Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Active Directory Groups] authorization_code support #24777

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@ennozdd

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

added authorization code flow support for delegated permissions
modified apimodule to handle non default scopes when generating proper login urls

Screenshots

image

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* auth flow support

* groups-login-url

* removed the integration file

* added release notes

* docs improvments

* fixing unit test

* unit test fix

* unit passed

* better scope handling

* scope error fix

* error fix

* removed the integration file

* removed the wrong file

* added display

* removed comma

* another comma

* reverting api module

* removed scope parameter
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator labels Feb 21, 2023
@content-bot content-bot requested a review from yucohen February 21, 2023 14:35
@xsoar-bot
Copy link
Contributor

@xsoar-bot
Copy link
Contributor

@yucohen yucohen merged commit f590589 into master Feb 22, 2023
@yucohen yucohen deleted the contrib/ennozdd_azuregroups branch February 22, 2023 15:35
ayman-m pushed a commit to my-soar/content that referenced this pull request Feb 24, 2023
…4698) (demisto#24777)

* auth flow support

* groups-login-url

* removed the integration file

* added release notes

* docs improvments

* fixing unit test

* unit test fix

* unit passed

* better scope handling

* scope error fix

* error fix

* removed the integration file

* removed the wrong file

* added display

* removed comma

* another comma

* reverting api module

* removed scope parameter

Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com>
Co-authored-by: yucohen <86777474+yucohen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants