arista-switch-pack #26554
Merged
arista-switch-pack #26554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
* Added the base code * more structural changes * added yml and description * added a test * commit * Adding tests * added tests and documentation * removed a duplicate yml conf * commit * commit * commit * commit * commit * changed events typo * formating the code * changes with nextLink * added support for the pagination * commit * commit * commit * modified some tests * Finished the tests and some fixes found by tests * added some test and removed the first fetch time param * fixed a test and some bugs in the code * fixed extra arg in test_module * commit * fixes * commit * Added modelign rules * added the rule * changes in yml and description * Added documentation to functions * Added documentation to tests * removed a file * changed to type 9 and bumped docker image * Update Packs/AzureSecurityCenter/Integrations/MicrosoftDefenderForCloudEventCollector/MicrosoftDefenderForCloudEventCollector_description.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixed a typo in microsoft * changes after doc review * small change in readme.md * fix validations * commit * change in the modeling rules * Added a first_fetch_time handeling * changed the modeling rule of event.outcome_reason * Added the first_fetch time parameter * Empty-Commit * review changes * added some known limitations * changed the hyrarcy of the modeling rules * fixed xif * modeling rules change names * Fixed the modeling rules * updated docker image * removed the RN for the new pack * minor readme changes * Apply suggestions from code review Docs review. Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * added RN and bumped version --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
|
Hey, Seems that this PR validations fail only due to Modeling Rules Test-Data mismtaches. They occur because the modeling rules use a [RULE] stanza section, There is a dev-task issue for this matter: Hence, requesting a force merge for this PR. Chanan @evisochek FYI |
cweltPA
added
the
ForceMerge
evisochek
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6624
Description
A new XSIAM pack for Arista EOS Switches.