Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Marketplace Contribution] FullHunt #26997

Merged
merged 9 commits into from
Jun 14, 2023
Merged

[Marketplace Contribution] FullHunt #26997

merged 9 commits into from
Jun 14, 2023

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@Sam0x90

Description

Integration with FullHunt, the attack surface database of the internet.
FullHunt enables companies to discover all of their attack surfaces, monitor them for exposure, and continuously scan them for the latest security vulnerabilities.

Notes

This integration leverages the basics features of FullHunt not the enterprise version. So basically it is used mainly to enrich data like domains.
Founder of FullHunt is aware and might update the pack later this year with additional features.

Auto-Generated Documentation Requiring Modification

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

Sorry, something went wrong.

@xsoar-bot
"pack contribution initial commit"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1e4c984
@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label May 25, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_Sam0x90-contrib-FullHunt May 25, 2023 15:18
@content-bot content-bot requested a review from thefrieddan1 May 25, 2023 15:18
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @thefrieddan1 will very shortly look over your proposed changes.

@thefrieddan1 thefrieddan1 added Community Community Support Level Indicates that the contribution is for Community supported pack labels May 28, 2023
@thefrieddan1
Copy link
Contributor

Hi  @Sam0x90,
thank you for your contribution we appreciate your effort, I reviewed the content in the PR and would like to provide some feedback:
Please see other integration packs in order to understand how to build a new Pack and integration.
If possible also please try and locally test run an instance of your integration before Pull Request on a local XSOAR.
Using the demito-sdk

General notes:

  1. Instance configuration does not exist in your yml file.
  2. Commands should be listed in the yml file.
    Commands naming conventions is integration name - command - name for example :
    FullHuntIO-say-hello
  3. your commands methods are not implemented in the FullHuntIO.py file.
  4. implement client methods.

The Pack still requires more work,
I think it is best to move it to draft until it is ready.
please let me know if you need more information to get it done.

Thanks,

@thefrieddan1 thefrieddan1 added the pending-contributor The PR is pending the response of its creator label May 28, 2023
@xsoar-bot
Copy link
Contributor Author

Contribution Pack Resubmitted

Contributor: @Sam0x90

Notes

Update of the PR with the "real" files from the integration.
I made a mistake in the previous PR by pushing an old automation script... Sorry for that.

thefrieddan1
thefrieddan1 reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@thefrieddan1 thefrieddan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thank you for your contribution we appreciate your effort, I reviewed the content in the PR and would like to provide some feedback:

@thefrieddan1 thefrieddan1 added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed pending-contributor The PR is pending the response of its creator labels Jun 1, 2023
@content-bot
Copy link
Collaborator

content-bot commented Jun 1, 2023 •
edited
Loading

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5517347

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Sam0x90
Copy link
Contributor

Sam0x90 commented Jun 1, 2023

Changes pushed as per @thefrieddan1 feedback.

@thefrieddan1
Copy link
Contributor

Hi,
Just need final touch up and tiding.
There are failures regarding missing commands in yml which appear in README
Also image is smaller than recommended.
You can run
demisto-sdk validate -i Packs/FullHunt/Integrations/FullHunt
In order to check locally if all is in order.

Thanks

@Sam0x90
Copy link
Contributor

Sam0x90 commented Jun 2, 2023

Hi, Just need final touch up and tiding. There are failures regarding missing commands in yml which appear in README Also image is smaller than recommended. You can run demisto-sdk validate -i Packs/FullHunt/Integrations/FullHunt In order to check locally if all is in order.

Thanks

Done as requested, pack metadata updated, yml fixed, image adjusted.

@thefrieddan1
Copy link
Contributor

Hi @contributor_user,
Although we greatly appreciate your contribution, it has been rejected for the following reason:
No demo scheduled. Validations are failing after comments and a branch was supplied to fix those.

Thank you for understanding.
We look forward to receiving more contributions from you in the future.

@thefrieddan1 thefrieddan1 reopened this Jun 13, 2023
@thefrieddan1 thefrieddan1 merged commit f49c2d6 into demisto:contrib/xsoar-contrib_Sam0x90-contrib-FullHunt Jun 14, 2023
@content-bot content-bot mentioned this pull request Jun 14, 2023
Merged
4 tasks
thefrieddan1 added a commit that referenced this pull request Jun 14, 2023
@content-bot @xsoar-bot
@Sam0x90 @thefrieddan1
[Marketplace Contribution] FullHunt (#26997) (#27421)
7cbcb3f 
* "pack contribution initial commit"

* pack resubmitted

* Update as per PAN feedback

* Update of yml and image as per PAN request

* Update as per PAN comments

* Bump docker version.

* Fix validations issues.

* Change command name in README file.

* Handle secrets

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Sam0x90 <sam0x90@outlook.com>
Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
@xsoar-bot xsoar-bot deleted the Sam0x90-contrib-FullHunt branch November 23, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sam0x90 Sam0x90

@thefrieddan1 thefrieddan1

Assignees

@thefrieddan1 thefrieddan1

Labels
Community Support Level Indicates that the contribution is for Community supported pack Community Contribution Thank you! Contributions are always welcome! docs-approved post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xsoar-bot @content-bot @thefrieddan1 @CLAassistant @Sam0x90