Zendesk enhancement #27101
Merged
Zendesk enhancement #27101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShahafBenYakir Doc review completed. |
| """ | ||
| attachments_ids = [] | ||
| ticket_id = ticket['id'] | ||
| comments_list = self._get_comments(ticket_id=ticket_id) |
There was a problem hiding this comment.
Are we sure _get_comments returns a list? if so let's add return type tp the function
There was a problem hiding this comment.
This is still missing the return type
…zendesk-enhancement # Conflicts: # Packs/Zendesk/pack_metadata.json
ShahafBenYakir
approved these changes
Jun 22, 2023
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* First commit * Added new command "zendesk-group-user-list" * Update release notes * Added html_comment to the create and update ticket + README updates * Updated rn * just a commit * Added another command + updated TPB + Updated incoming mapper * Added test + small fixes * Remove comment * flake8 * Fixed docs notes * Update docker * Bump pack from version Zendesk to 2.0.8. * Some CR comments * Fixed release notes version * Fixed release notes version * Fixed cr comments + updated image * Fix tests * - * - * Last comment --------- Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* First commit * Added new command "zendesk-group-user-list" * Update release notes * Added html_comment to the create and update ticket + README updates * Updated rn * just a commit * Added another command + updated TPB + Updated incoming mapper * Added test + small fixes * Remove comment * flake8 * Fixed docs notes * Update docker * Bump pack from version Zendesk to 2.0.8. * Some CR comments * Fixed release notes version * Fixed release notes version * Fixed cr comments + updated image * Fix tests * - * - * Last comment --------- Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6450, https://jira-hq.paloaltonetworks.local/browse/CIAC-5638
Description
commentandhtml_commentto thezendesk-ticket-createcommandhtml_commenttozendesk-ticket-updatecommandDoes it break backward compatibility?
Must have