Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align credentials stores part 12 #27255

Merged
merged 23 commits into from
Jun 22, 2023
Merged

Align credentials stores part 12 #27255

merged 23 commits into from
Jun 22, 2023

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Jun 6, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag
Copy link
Contributor Author

maimorag commented Jun 7, 2023

Notes regarding ServiceDestPlus:

  1. Test playbook fails, there is an open issue regarding it. Therefore the changes in the code are not causing it. link to Jirra issue
  2. The args Client ID and Client Secret type:4 are in the combined param credentials_client of type:9 -> Is it ok?

@maimorag maimorag requested a review from Shellyber June 7, 2023 11:53
@Shellyber
Copy link
Contributor

Notes regarding ServiceDestPlus:

  1. Test playbook fails, there is an open issue regarding it. Therefore the changes in the code are not causing it. link to Jirra issue
  2. The args Client ID and Client Secret type:4 are in the combined param credentials_client of type:9 -> Is it ok?
  1. Did you try to fix the test? understand why it fails?
  2. Yes, that's ok.

@maimorag
Copy link
Contributor Author

@Shellyber @JudahSchwartz The test fails since the secret key is expired. I looking for a way to renew it

@maimorag
Copy link
Contributor Author

a refresh_token had been generated in order to fix the playbook issue link to Jirra issue

maimorag and others added 14 commits June 12, 2023 10:43
@maimorag
docker image
7f3e90c
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
772b2a3
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
5d1c10d
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
92f5642
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
7759612
@maimorag
Merge remote-tracking branch 'origin/master' into align_credentials_s…
f25524f 
…tores_part_12
@maimorag
Merge remote-tracking branch 'origin/master' into align_credentials_s…
1a42a74 
…tores_part_12
@maimorag
docker
9860123
@maimorag
Merge remote-tracking branch 'origin/master' into align_credentials_s…
298dd59 
…tores_part_12
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
45f3e36
@maimorag
fix
5ac3876
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
e530413
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
bc1f5b3
@maimorag
Merge branch 'master' into align_credentials_stores_part_12
1d11b85
@maimorag maimorag requested a review from Shellyber June 21, 2023 14:39
@maimorag maimorag merged commit 6f55204 into master Jun 22, 2023
@maimorag maimorag deleted the align_credentials_stores_part_12 branch June 22, 2023 11:38
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
@maimorag @MosheEichler
Align credentials stores part 12 (#27255)
21616fc 
* Align credentials stores part 12

* fix

* fix

* undoing last change

* docker image

* docker

* fix

* raise error
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
@maimorag @xsoar-bot
Align credentials stores part 12 (demisto#27255)
eb8847c 
* Align credentials stores part 12

* fix

* fix

* undoing last change

* docker image

* docker

* fix

* raise error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shellyber Shellyber Shellyber approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maimorag @Shellyber