-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threat connect outputs #27257
Merged
Merged
Threat connect outputs #27257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed argument description
Fixed argument description
…eat-connect-outputs
…eat-connect-outputs
gal-forer
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, maybe just remove the comments from the code
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* refactored code to align with standard * Fixed owner argument * Fixed unittests * Mypy fixes * reverted name change * reverted argument deprecation * Added RN and version Fixed argument description * Added RN and version Fixed argument description * bumped docker * fxied docs * fixed docs * adjusted readme * removed commented code
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* refactored code to align with standard * Fixed owner argument * Fixed unittests * Mypy fixes * reverted name change * reverted argument deprecation * Added RN and version Fixed argument description * Added RN and version Fixed argument description * bumped docker * fxied docs * fixed docs * adjusted readme * removed commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6139
Description
Added the ability to add more fields to the outputs of the indicator commands