Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threat connect outputs #27257

Merged
merged 20 commits into from
Jun 23, 2023
Merged

Threat connect outputs #27257

merged 20 commits into from
Jun 23, 2023

Conversation

ShahafBenYakir
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6139

Description

Added the ability to add more fields to the outputs of the indicator commands

Copy link
Contributor

@gal-forer gal-forer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, maybe just remove the comments from the code

@ShahafBenYakir ShahafBenYakir marked this pull request as ready for review June 23, 2023 09:16
@ShahafBenYakir ShahafBenYakir merged commit bb29b74 into master Jun 23, 2023
@ShahafBenYakir ShahafBenYakir deleted the threat-connect-outputs branch June 23, 2023 09:17
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* refactored code to align with standard

* Fixed owner argument

* Fixed unittests

* Mypy fixes

* reverted name change

* reverted argument deprecation

* Added RN and version
Fixed argument description

* Added RN and version
Fixed argument description

* bumped docker

* fxied docs

* fixed docs

* adjusted readme

* removed commented code
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* refactored code to align with standard

* Fixed owner argument

* Fixed unittests

* Mypy fixes

* reverted name change

* reverted argument deprecation

* Added RN and version
Fixed argument description

* Added RN and version
Fixed argument description

* bumped docker

* fxied docs

* fixed docs

* adjusted readme

* removed commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants