Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores part 13 #27289

Merged
merged 24 commits into from
Jun 22, 2023
Merged

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Jun 7, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag maimorag requested a review from Shellyber June 7, 2023 15:09
@maimorag
Copy link
Contributor Author

maimorag commented Jun 8, 2023

pwnd test fail- existing problem link to jira issue

@Shellyber
Copy link
Contributor

Shellyber commented Jun 8, 2023

pwnd test fail- existing problem link to jira issue

@maimorag It seems that we have credentials for this.
Did you check why the test failed? tried to fix it?

@maimorag
Copy link
Contributor Author

maimorag commented Jun 21, 2023

fails since the Tenable.io account had expired - link to Jira ticket

@maimorag maimorag requested a review from Shellyber June 22, 2023 07:19
@maimorag maimorag requested a review from Shellyber June 22, 2023 11:00
@maimorag maimorag added the ForceMerge Forcing the merge of the PR despite the build status label Jun 22, 2023
@dantavori dantavori merged commit 5cd9536 into master Jun 22, 2023
@dantavori dantavori deleted the align_credentials_stores_part_13 branch June 22, 2023 12:19
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* Align credentials stores for all Cortex Marketplace integrations- part 13

* adding Tenable_io

* fix

* Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.py

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* docker update

* added tests

* try

* adding print

* try fix

* removed fixed

* over intended

* added unit tests

* docker image

* headers

* raise DemistoExceptio

* update

---------

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Align credentials stores for all Cortex Marketplace integrations- part 13

* adding Tenable_io

* fix

* Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.py

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* docker update

* added tests

* try

* adding print

* try fix

* removed fixed

* over intended

* added unit tests

* docker image

* headers

* raise DemistoExceptio

* update

---------

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants