Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Credentials for GSuiteAdmin, SymantecMSS, AlienVault_USM_Anywhere, AttackIQFireDrill #27583

Merged
merged 12 commits into from
Jun 25, 2023

Conversation

jlevypaloalto
Copy link
Contributor

@jlevypaloalto jlevypaloalto commented Jun 20, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-7056

Description

Align Credentials for GSuiteAdmin, SymantecMSS, AlienVault_USM_Anywhere, AttackIQFireDrill.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

Sorry, something went wrong.

@jlevypaloalto
Copy link
Contributor Author

This PR must be force-merged as SymantecMSS has no unit-tests.

@jlevypaloalto jlevypaloalto added the ForceMerge Forcing the merge of the PR despite the build status label Jun 23, 2023
@@ -86,7 +87,7 @@ def api_call(body, headers):
res = requests.post(url=SERVER_URL + "/SWS/incidents.asmx", cert=cert, data=body, headers=headers)
if res.status_code < 200 or res.status_code >= 300:
raise Exception(
"Got status code " + str(res.status_code) + " with body " + res.content + " with headers " + str(
"Got status code " + str(res.status_code) + " with body " + str(res.content) + " with headers " + str(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

res.content can also be a bytes object so ruff or mypy were complaining.

@ShahafBenYakir ShahafBenYakir merged commit cd8be5c into master Jun 25, 2023
@ShahafBenYakir ShahafBenYakir deleted the jl-align-creds-6 branch June 25, 2023 10:13
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
…re, AttackIQFireDrill (#27583)

* GSuiteAdmin complete

* SymantecMSS complete

* AlienVault_USM_Anywhere complete

* AlienVault_USM_Anywhere complete

* AttackIQFireDrill complete

* fixed syntax errors

* added certificate_creds

* update docker

* removed creds for certificate

* require cert in symantec
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
…re, AttackIQFireDrill (demisto#27583)

* GSuiteAdmin complete

* SymantecMSS complete

* AlienVault_USM_Anywhere complete

* AlienVault_USM_Anywhere complete

* AttackIQFireDrill complete

* fixed syntax errors

* added certificate_creds

* update docker

* removed creds for certificate

* require cert in symantec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants