-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Credentials for GSuiteAdmin, SymantecMSS, AlienVault_USM_Anywhere, AttackIQFireDrill #27583
Merged
+97
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR must be force-merged as SymantecMSS has no unit-tests. |
JudahSchwartz
approved these changes
Jun 25, 2023
@@ -86,7 +87,7 @@ def api_call(body, headers): | |||
res = requests.post(url=SERVER_URL + "/SWS/incidents.asmx", cert=cert, data=body, headers=headers) | |||
if res.status_code < 200 or res.status_code >= 300: | |||
raise Exception( | |||
"Got status code " + str(res.status_code) + " with body " + res.content + " with headers " + str( | |||
"Got status code " + str(res.status_code) + " with body " + str(res.content) + " with headers " + str( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
res.content can also be a bytes object so ruff or mypy were complaining.
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
…re, AttackIQFireDrill (#27583) * GSuiteAdmin complete * SymantecMSS complete * AlienVault_USM_Anywhere complete * AlienVault_USM_Anywhere complete * AttackIQFireDrill complete * fixed syntax errors * added certificate_creds * update docker * removed creds for certificate * require cert in symantec
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
…re, AttackIQFireDrill (demisto#27583) * GSuiteAdmin complete * SymantecMSS complete * AlienVault_USM_Anywhere complete * AlienVault_USM_Anywhere complete * AttackIQFireDrill complete * fixed syntax errors * added certificate_creds * update docker * removed creds for certificate * require cert in symantec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: CIAC-7056
Description
Align Credentials for GSuiteAdmin, SymantecMSS, AlienVault_USM_Anywhere, AttackIQFireDrill.
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have