Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[marketplace contributions] - fix issue with support labels #27600

Merged
merged 16 commits into from
Jun 26, 2023

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Jun 20, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Fixed an issue where support labels were not added specifically in marketplace contributions. See the issues comment for further explanation
  • In case checkout to the contributor's branch fails, fallback to master branch to try to retrieve the support levels of packs.

@GuyAfik
Copy link
Contributor Author

GuyAfik commented Jun 21, 2023

along with @dansterenson we were able to check that this fix works on marketplace contributions too with this testing PR #27617

@ShacharKidor fyi

Copy link
Contributor

@ShacharKidor ShacharKidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Please add a UT for testing MP contributions changes.

Utils/github_workflow_scripts/handle_external_pr.py Outdated Show resolved Hide resolved
@GuyAfik
Copy link
Contributor Author

GuyAfik commented Jun 22, 2023

working version on the latest commit for marketplace contributions: #27657
working version on the latest commit for github contributions: #27720

@GuyAfik GuyAfik added the ForceMerge Forcing the merge of the PR despite the build status label Jun 26, 2023
@GuyAfik
Copy link
Contributor Author

GuyAfik commented Jun 26, 2023

needs force-merge, as the test-upload-flow is broken with validations failing which are un-related to this PR.

@dantavori dantavori merged commit c9d3bc2 into master Jun 26, 2023
@dantavori dantavori deleted the fix_marketplace_contributions_support_labels_bug branch June 26, 2023 14:58
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* [marketplace contributions] - fix issue where support labels are not added

* add unit-tests

* update comment

* update path of test

* path cwd

* fallback to master in case checkout failed

* docstrings improvments

* update print string

* add prints
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
…27600)

* [marketplace contributions] - fix issue where support labels are not added

* add unit-tests

* update comment

* update path of test

* path cwd

* fallback to master in case checkout failed

* docstrings improvments

* update print string

* add prints
israelpoli pushed a commit that referenced this pull request May 15, 2024
* [marketplace contributions] - fix issue where support labels are not added

* add unit-tests

* update comment

* update path of test

* path cwd

* fallback to master in case checkout failed

* docstrings improvments

* update print string

* add prints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants